All of lore.kernel.org
 help / color / mirror / Atom feed
From: Stefan Roese <sr@denx.de>
To: u-boot@lists.denx.de
Subject: [U-Boot-Users] [RFC] [PATCH 2/2] [new uImage] Avoid initrd and logbuffer area overlaps
Date: Sat, 10 May 2008 06:17:43 +0200	[thread overview]
Message-ID: <200805100617.43643.sr@denx.de> (raw)
In-Reply-To: <20080507110859.10627.96876.stgit@hekate.izotz.org>

On Wednesday 07 May 2008, Marian Balakowicz wrote:
> Add logbuffer to reserved LMB areas to prevent initrd allocation
> from overlaping with it.
>
> Make sure to use correct logbuffer base address.
>
> Signed-off-by: Marian Balakowicz <m8@semihalf.com>

Hmmm, this patch breaks all PPC boards without logbuffer support. Take a look 
at "acadia" for example:

[stefan at kubuntu u-boot (master)]$ ./MAKEALL acadia
Configuring for acadia board...
board.c: In function 'logbuffer_base':
board.c:403: error: 'LOGBUFF_LEN' undeclared (first use in this function)
board.c:403: error: (Each undeclared identifier is reported only once
board.c:403: error: for each function it appears in.)
make[1]: *** [board.o] Error 1
make: *** [lib_ppc/libppc.a] Error 2

I tried to quickly (#ifdef around the logbuffer_base() function in 
lib_ppc/board.c) fix it but it didn't work. So it would be great if you could 
come up with a fix for this.

Thanks.

Best regards,
Stefan

=====================================================================
DENX Software Engineering GmbH,     MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: +49-8142-66989-0 Fax: +49-8142-66989-80  Email: office at denx.de
=====================================================================

  parent reply	other threads:[~2008-05-10  4:17 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-05-07 11:08 [U-Boot-Users] [PATCH 1/2] ppc: Cleanup get_effective_memsize() use Marian Balakowicz
2008-05-07 11:10 ` [U-Boot-Users] [RFC] [PATCH 2/2] [new uImage] Avoid initrd and logbuffer area overlaps Marian Balakowicz
2008-05-09 22:16   ` Wolfgang Denk
2008-05-10  4:17   ` Stefan Roese [this message]
2008-05-11 23:00     ` Wolfgang Denk
2008-05-12 10:56       ` Marian Balakowicz
2008-05-09 22:14 ` [U-Boot-Users] [PATCH 1/2] ppc: Cleanup get_effective_memsize() use Wolfgang Denk

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=200805100617.43643.sr@denx.de \
    --to=sr@denx.de \
    --cc=u-boot@lists.denx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.