All of lore.kernel.org
 help / color / mirror / Atom feed
From: Marian Balakowicz <m8@semihalf.com>
To: u-boot@lists.denx.de
Subject: [U-Boot-Users] [RFC] [PATCH 2/2] [new uImage] Avoid initrd and logbuffer area overlaps
Date: Mon, 12 May 2008 12:56:00 +0200	[thread overview]
Message-ID: <48282240.50405@semihalf.com> (raw)
In-Reply-To: <20080511230023.BEAAD248C8@gemini.denx.de>


Dear Wolfgang,

Wolfgang Denk wrote:
> 
> in message <200805100617.43643.sr@denx.de> Stefan Roese wrote:
>>> Add logbuffer to reserved LMB areas to prevent initrd allocation
>>> from overlaping with it.
>>>
>>> Make sure to use correct logbuffer base address.
>>>
>>> Signed-off-by: Marian Balakowicz <m8@semihalf.com>
>> Hmmm, this patch breaks all PPC boards without logbuffer support. Take a look 
>> at "acadia" for example:
> 
> Indeed. It is obvious that this patch was not even minimally tested.
> Please see "Note 2" at http://www.denx.de/wiki/UBoot/Patches

That is true, but the patch was explicitly marked RFC, as I was hoping
to hear possible comments on the approach first.

> I reverted the patch. Please resubmit after fixing the problems.

Will do.

Cheers,
Marian

  reply	other threads:[~2008-05-12 10:56 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-05-07 11:08 [U-Boot-Users] [PATCH 1/2] ppc: Cleanup get_effective_memsize() use Marian Balakowicz
2008-05-07 11:10 ` [U-Boot-Users] [RFC] [PATCH 2/2] [new uImage] Avoid initrd and logbuffer area overlaps Marian Balakowicz
2008-05-09 22:16   ` Wolfgang Denk
2008-05-10  4:17   ` Stefan Roese
2008-05-11 23:00     ` Wolfgang Denk
2008-05-12 10:56       ` Marian Balakowicz [this message]
2008-05-09 22:14 ` [U-Boot-Users] [PATCH 1/2] ppc: Cleanup get_effective_memsize() use Wolfgang Denk

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=48282240.50405@semihalf.com \
    --to=m8@semihalf.com \
    --cc=u-boot@lists.denx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.