From: Ken Moffat <zarniwhoop@ntlworld.com>
To: Daniel Barkalow <barkalow@iabervon.org>
Cc: Roland Dreier <rdreier@cisco.com>,
Rene Herman <rene.herman@keyaccess.nl>,
Adrian Bunk <bunk@kernel.org>,
Linux Kernel <linux-kernel@vger.kernel.org>,
Linus Torvalds <torvalds@linux-foundation.org>
Subject: Re: GIT bisection range errors
Date: Sat, 10 May 2008 17:52:21 +0100 [thread overview]
Message-ID: <20080510165220.GA3898@deepthought> (raw)
In-Reply-To: <alpine.LNX.1.00.0805091714050.19665@iabervon.org>
On Fri, May 09, 2008 at 05:45:00PM -0400, Daniel Barkalow wrote:
> On Fri, 9 May 2008, Ken Moffat wrote:
>
> >
> > But, surely those of us who bisect against linus' tree only
> > care about the commits which made it into his tree, and in the
> > context of whatever else was in _his_ tree at the time ?
> >
> > Maybe I'm under a misapprehension about changesets and merges. I
> > thought a merge was just pulling in a series of changesets, and that
> > each changeset only contains related items (comment, changed lines,
> > added files, deleted files).
>
> No, git tracks states and where they came from, not changes per se. That
> is, when you look at a commit by David Miller, you're looking at exactly
> the file contents that David Miller had when making the commit. Some other
> systems linearize history such that what you'd see in Linus's tree is what
> David Miller would have had if he'd made his changes to the tree Linus had
> before merging David's branch, but that's not the normal thing to do with
> git in this case.
That was the root cause of my misunderstanding - I thought it was
tracking the changes themselves.
>
> > Whatever else may be in tree E, I don't expect it to have a commit
> > which changes $EXTRAVERSION, purely because tree E is not Linus'
> > tree. To me, that field is somewhat special - it indicates where I am
> > (e.g. if bisecting across multiple rcs, or even across multiple
> > releases) and it determines where the modules will go.
>
> Tree E doesn't change versions; it's got the same version as A. But C and
> D pick up the version change from B, which means that C and E have
> different versions. You could also look at it like this: going back from D
> to F changes the version, not because anybody on the lower path changed
> it, but because Linus included the version change from his own side when
> doing the merge.
>
OK, I think I understand that now.
> > I see from Linus' reply to the original mail that this is indeed
> > normal. That certainly isn't the word I would choose to use : we
> > give things names to describe them and in this case the EXTRAVERSION
> > appears to inhabit a parrallel universe to the pre-existing usage
> > of "2.6.24 good, 2.6.25-rc1 bad". Colour me more confused than ever.
>
> 2.6.26-rc1 is bad, 2.6.25 is good, vanilla 2.6.25-rc1 is good, but some
> modified version of 2.6.25-rc1 was bad. It's like if you take 2.6.25, and
> you leave the Makefile the same but change some driver. You can find that
> your 2.6.25 is now broken, while the original 2.6.25 is not. What's going
> on in this bisect run is that Rene's seeing this same situation, but from
> the perspective of looking back from the future and looking at somebody
> else's state.
>
Many thanks for taking the time to explain this in detail!
Ken
--
das eine Mal als Tragödie, das andere Mal als Farce
next prev parent reply other threads:[~2008-05-10 16:52 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-05-08 22:20 GIT bisection range errors Rene Herman
2008-05-08 22:25 ` Adrian Bunk
2008-05-08 22:36 ` Rene Herman
2008-05-08 22:56 ` Ken Moffat
2008-05-08 23:33 ` Roland Dreier
2008-05-09 1:12 ` Rene Herman
2008-05-09 21:10 ` Ken Moffat
2008-05-09 21:45 ` Daniel Barkalow
2008-05-10 16:52 ` Ken Moffat [this message]
2008-05-08 23:00 ` Linus Torvalds
2008-05-08 23:12 ` Rene Herman
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20080510165220.GA3898@deepthought \
--to=zarniwhoop@ntlworld.com \
--cc=barkalow@iabervon.org \
--cc=bunk@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=rdreier@cisco.com \
--cc=rene.herman@keyaccess.nl \
--cc=torvalds@linux-foundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.