All of lore.kernel.org
 help / color / mirror / Atom feed
From: Christoph Hellwig <hch@infradead.org>
To: Mike Frysinger <vapier.adi@gmail.com>
Cc: Bryan Wu <cooloney@kernel.org>,
	linux-kernel@vger.kernel.org, linux-mm@kvack.org,
	dwmw2@infradead.org, Vivi Li <vivi.li@analog.com>
Subject: Re: [PATCH 4/4] [MM/NOMMU]: Export two symbols in nommu.c for mmap test
Date: Mon, 12 May 2008 09:00:58 -0400	[thread overview]
Message-ID: <20080512130058.GA8981@infradead.org> (raw)
In-Reply-To: <8bd0f97a0805120338l1d7e0e7eiffebae3bf33c172c@mail.gmail.com>

On Mon, May 12, 2008 at 06:38:55AM -0400, Mike Frysinger wrote:
> On Mon, May 12, 2008 at 6:32 AM, Bryan Wu <cooloney@kernel.org> wrote:
> > From: Vivi Li <vivi.li@analog.com>
> >
> > http://blackfin.uclinux.org/gf/project/uclinux-dist/tracker/?action=TrackerItemEdit&tracker_item_id=2312
> 
> i dont think URLs to our tracker is a good substitute for log
> messages.  our tracker URLs have known to break in the past (due to
> gforge changes), and it's a pain for people reading changelogs to open
> up a browser just to see what the issue is about.

Yeah, even the url pointer to there is totally unreadable.  I still
don't understand why you want to export this symbols.  Also please make
sure to always submit the code actually using the exports in the same
patchkit, that makes it a lot easier to figure.

WARNING: multiple messages have this Message-ID (diff)
From: Christoph Hellwig <hch@infradead.org>
To: Mike Frysinger <vapier.adi@gmail.com>
Cc: Bryan Wu <cooloney@kernel.org>,
	linux-kernel@vger.kernel.org, linux-mm@kvack.org,
	dwmw2@infradead.org, Vivi Li <vivi.li@analog.com>
Subject: Re: [PATCH 4/4] [MM/NOMMU]: Export two symbols in nommu.c for mmap test
Date: Mon, 12 May 2008 09:00:58 -0400	[thread overview]
Message-ID: <20080512130058.GA8981@infradead.org> (raw)
In-Reply-To: <8bd0f97a0805120338l1d7e0e7eiffebae3bf33c172c@mail.gmail.com>

On Mon, May 12, 2008 at 06:38:55AM -0400, Mike Frysinger wrote:
> On Mon, May 12, 2008 at 6:32 AM, Bryan Wu <cooloney@kernel.org> wrote:
> > From: Vivi Li <vivi.li@analog.com>
> >
> > http://blackfin.uclinux.org/gf/project/uclinux-dist/tracker/?action=TrackerItemEdit&tracker_item_id=2312
> 
> i dont think URLs to our tracker is a good substitute for log
> messages.  our tracker URLs have known to break in the past (due to
> gforge changes), and it's a pain for people reading changelogs to open
> up a browser just to see what the issue is about.

Yeah, even the url pointer to there is totally unreadable.  I still
don't understand why you want to export this symbols.  Also please make
sure to always submit the code actually using the exports in the same
patchkit, that makes it a lot easier to figure.

--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org.  For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>

  reply	other threads:[~2008-05-12 13:01 UTC|newest]

Thread overview: 30+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-05-12 10:32 [PATCH 0/4] Memory management patches from Blackfin team Bryan Wu
2008-05-12 10:32 ` Bryan Wu
2008-05-12 10:32 ` [PATCH 1/4] [mm] buddy page allocator: add tunable big order allocation Bryan Wu
2008-05-12 10:32   ` Bryan Wu, Michael Hennerich
2008-05-13  2:09   ` KAMEZAWA Hiroyuki
2008-05-13  2:09     ` KAMEZAWA Hiroyuki
2008-05-13 11:42     ` Hennerich, Michael
2008-05-13 11:42       ` Hennerich, Michael
2008-05-14  4:22       ` Bryan Wu
2008-05-14  4:22         ` Bryan Wu
2008-05-14  5:04         ` KAMEZAWA Hiroyuki
2008-05-14  5:04           ` KAMEZAWA Hiroyuki
2008-05-12 10:32 ` [PATCH 2/4] [NOMMU]: include the problematic mapping in the munmap warning Bryan Wu
2008-05-12 10:32   ` Bryan Wu, Mike Frysinger
2008-05-15  6:33   ` Bryan Wu
2008-05-15  6:33     ` Bryan Wu
2008-05-12 10:32 ` [PATCH 3/4] [mm/nommu]: use copy_to_user_page to call flush icache for [#811] toolchain old bug Bryan Wu
2008-05-12 10:32   ` Bryan Wu, Jie Zhang
2008-05-15  6:24   ` Bryan Wu
2008-05-15  6:24     ` Bryan Wu
2008-05-12 10:32 ` [PATCH 4/4] [MM/NOMMU]: Export two symbols in nommu.c for mmap test Bryan Wu
2008-05-12 10:32   ` Bryan Wu, Vivi Li
2008-05-12 10:38   ` Mike Frysinger
2008-05-12 10:38     ` Mike Frysinger
2008-05-12 13:00     ` Christoph Hellwig [this message]
2008-05-12 13:00       ` Christoph Hellwig
2008-05-12 13:02       ` Mike Frysinger
2008-05-12 13:02         ` Mike Frysinger
2008-05-13  7:09         ` Bryan Wu
2008-05-13  7:09           ` Bryan Wu

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20080512130058.GA8981@infradead.org \
    --to=hch@infradead.org \
    --cc=cooloney@kernel.org \
    --cc=dwmw2@infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-mm@kvack.org \
    --cc=vapier.adi@gmail.com \
    --cc=vivi.li@analog.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.