* [Patch]: Cgroups: Fix compile warning: incompatible types in kernel/sched.c on 2.6.26-rc1
@ 2008-05-12 2:12 Mirco Tischler
2008-05-12 2:34 ` Paul Menage
0 siblings, 1 reply; 3+ messages in thread
From: Mirco Tischler @ 2008-05-12 2:12 UTC (permalink / raw)
To: Ingo Molnar, lkml, Paul Menage
[-- Attachment #1: Type: text/plain, Size: 891 bytes --]
Hi
I've got this warning on 2.6.26-rc1 on compile:
> CC kernel/sched.o
> kernel/sched.c:9026: warning: initialization from incompatible pointer type
>
This patch fixes it.
Thanks
Mirco
Cgroups: Fix compile warning: incompatible types in kernel/sched.c
Return type of cpu_rt_runtime_write() should be int instead of ssize_t.
Signed-off-by: Mirco Tischler <mt-ml@gmx.de>
diff --git a/kernel/sched.c b/kernel/sched.c
index c51b656..ba91376 100644
--- a/kernel/sched.c
+++ b/kernel/sched.c
@@ -8988,7 +8988,7 @@ static u64 cpu_shares_read_u64(struct cgroup *cgrp, struct cftype *cft)
#endif
#ifdef CONFIG_RT_GROUP_SCHED
-static ssize_t cpu_rt_runtime_write(struct cgroup *cgrp, struct cftype *cft,
+static int cpu_rt_runtime_write(struct cgroup *cgrp, struct cftype *cft,
s64 val)
{
return sched_group_set_rt_runtime(cgroup_tg(cgrp), val);
[-- Attachment #2: This is a digitally signed message part --]
[-- Type: application/pgp-signature, Size: 189 bytes --]
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [Patch]: Cgroups: Fix compile warning: incompatible types in kernel/sched.c on 2.6.26-rc1
2008-05-12 2:12 [Patch]: Cgroups: Fix compile warning: incompatible types in kernel/sched.c on 2.6.26-rc1 Mirco Tischler
@ 2008-05-12 2:34 ` Paul Menage
2008-05-13 13:24 ` Ingo Molnar
0 siblings, 1 reply; 3+ messages in thread
From: Paul Menage @ 2008-05-12 2:34 UTC (permalink / raw)
To: Mirco Tischler; +Cc: Ingo Molnar, lkml
On Sun, May 11, 2008 at 7:12 PM, Mirco Tischler <mt-ml@gmx.de> wrote:
> Hi
> I've got this warning on 2.6.26-rc1 on compile:
>> CC kernel/sched.o
>> kernel/sched.c:9026: warning: initialization from incompatible pointer type
>>
> This patch fixes it.
>
> Thanks
> Mirco
>
> Cgroups: Fix compile warning: incompatible types in kernel/sched.c
>
> Return type of cpu_rt_runtime_write() should be int instead of ssize_t.
>
> Signed-off-by: Mirco Tischler <mt-ml@gmx.de>
Acked-by: Paul Menage <menage@google.com>
Thanks.
Paul
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [Patch]: Cgroups: Fix compile warning: incompatible types in kernel/sched.c on 2.6.26-rc1
2008-05-12 2:34 ` Paul Menage
@ 2008-05-13 13:24 ` Ingo Molnar
0 siblings, 0 replies; 3+ messages in thread
From: Ingo Molnar @ 2008-05-13 13:24 UTC (permalink / raw)
To: Paul Menage; +Cc: Mirco Tischler, Ingo Molnar, lkml
* Paul Menage <menage@google.com> wrote:
> > Cgroups: Fix compile warning: incompatible types in kernel/sched.c
> >
> > Return type of cpu_rt_runtime_write() should be int instead of ssize_t.
> >
> > Signed-off-by: Mirco Tischler <mt-ml@gmx.de>
>
> Acked-by: Paul Menage <menage@google.com>
applied, thanks.
Ingo
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2008-05-13 13:25 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2008-05-12 2:12 [Patch]: Cgroups: Fix compile warning: incompatible types in kernel/sched.c on 2.6.26-rc1 Mirco Tischler
2008-05-12 2:34 ` Paul Menage
2008-05-13 13:24 ` Ingo Molnar
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.