All of lore.kernel.org
 help / color / mirror / Atom feed
* [Resend] [PATCH] ARM: OMAP: add RTC support to beagleboard
@ 2008-05-13  8:17 Koen Kooi
  2008-05-14 22:42 ` Tony Lindgren
  0 siblings, 1 reply; 4+ messages in thread
From: Koen Kooi @ 2008-05-13  8:17 UTC (permalink / raw)
  To: Tony Lindgren; +Cc: linux-omap

This patch adds RTC support to the omap3 based beagleboard

Signed-off-by: Koen Kooi <koen@openembedded.org>
---
  arch/arm/mach-omap2/board-omap3beagle.c |   12 ++++++++++++
  1 files changed, 12 insertions(+), 0 deletions(-)

diff --git a/arch/arm/mach-omap2/board-omap3beagle.c b/arch/arm/mach- 
omap2/board-omap3beagle.c
index 626f004..0c0cbfc 100644
--- a/arch/arm/mach-omap2/board-omap3beagle.c
+++ b/arch/arm/mach-omap2/board-omap3beagle.c
@@ -58,13 +58,25 @@ static struct omap_mmc_config  
omap3beagle_mmc_config __initdata = {
  	},
  };

+static struct platform_device omap3_beagle_twl4030rtc_device = {
+	.name           = "twl4030_rtc",
+	.id             = -1,
+};
+
  static struct omap_board_config_kernel omap3_beagle_config[]  
__initdata = {
  	{ OMAP_TAG_UART,	&omap3_beagle_uart_config },
  	{ OMAP_TAG_MMC,		&omap3beagle_mmc_config },
  };

+static struct platform_device *omap3_beagle_devices[] __initdata = {
+#ifdef CONFIG_RTC_DRV_TWL4030
+	&omap3_beagle_twl4030rtc_device,
+#endif
+};
+
  static void __init omap3_beagle_init(void)
  {
+	platform_add_devices(omap3_beagle_devices,  
ARRAY_SIZE(omap3_beagle_devices));
  	omap_board_config = omap3_beagle_config;
  	omap_board_config_size = ARRAY_SIZE(omap3_beagle_config);
  	omap_serial_init();
-- 
1.5.4.3



^ permalink raw reply related	[flat|nested] 4+ messages in thread

* Re: [Resend] [PATCH] ARM: OMAP: add RTC support to beagleboard
  2008-05-13  8:17 [Resend] [PATCH] ARM: OMAP: add RTC support to beagleboard Koen Kooi
@ 2008-05-14 22:42 ` Tony Lindgren
  2008-05-14 22:56   ` Felipe Balbi
  0 siblings, 1 reply; 4+ messages in thread
From: Tony Lindgren @ 2008-05-14 22:42 UTC (permalink / raw)
  To: Koen Kooi; +Cc: linux-omap

* Koen Kooi <k.kooi@student.utwente.nl> [080513 01:20]:
> This patch adds RTC support to the omap3 based beagleboard

I've pushed this after tweaking it manually again. It seems it was for
some older kernel? Also you should check your mail client or smtp server
to make sure patches don't wrap like this one is wrapped. It makes it
hard to read and apply them.

Anyways, can you please check that the patch got applied OK?

Thanks,

Tony


> Signed-off-by: Koen Kooi <koen@openembedded.org>
> ---
>  arch/arm/mach-omap2/board-omap3beagle.c |   12 ++++++++++++
>  1 files changed, 12 insertions(+), 0 deletions(-)
>
> diff --git a/arch/arm/mach-omap2/board-omap3beagle.c b/arch/arm/mach- 
> omap2/board-omap3beagle.c
> index 626f004..0c0cbfc 100644
> --- a/arch/arm/mach-omap2/board-omap3beagle.c
> +++ b/arch/arm/mach-omap2/board-omap3beagle.c
> @@ -58,13 +58,25 @@ static struct omap_mmc_config omap3beagle_mmc_config 
> __initdata = {
>  	},
>  };
>
> +static struct platform_device omap3_beagle_twl4030rtc_device = {
> +	.name           = "twl4030_rtc",
> +	.id             = -1,
> +};
> +
>  static struct omap_board_config_kernel omap3_beagle_config[] __initdata 
> = {
>  	{ OMAP_TAG_UART,	&omap3_beagle_uart_config },
>  	{ OMAP_TAG_MMC,		&omap3beagle_mmc_config },
>  };
>
> +static struct platform_device *omap3_beagle_devices[] __initdata = {
> +#ifdef CONFIG_RTC_DRV_TWL4030
> +	&omap3_beagle_twl4030rtc_device,
> +#endif
> +};
> +
>  static void __init omap3_beagle_init(void)
>  {
> +	platform_add_devices(omap3_beagle_devices,  
> ARRAY_SIZE(omap3_beagle_devices));
>  	omap_board_config = omap3_beagle_config;
>  	omap_board_config_size = ARRAY_SIZE(omap3_beagle_config);
>  	omap_serial_init();
> -- 
> 1.5.4.3
>
>

^ permalink raw reply	[flat|nested] 4+ messages in thread

* Re: [Resend] [PATCH] ARM: OMAP: add RTC support to beagleboard
  2008-05-14 22:42 ` Tony Lindgren
@ 2008-05-14 22:56   ` Felipe Balbi
  2008-05-15  6:41     ` Koen Kooi
  0 siblings, 1 reply; 4+ messages in thread
From: Felipe Balbi @ 2008-05-14 22:56 UTC (permalink / raw)
  To: Tony Lindgren; +Cc: Koen Kooi, linux-omap

On Wed, May 14, 2008 at 03:42:53PM -0700, Tony Lindgren wrote:
> * Koen Kooi <k.kooi@student.utwente.nl> [080513 01:20]:
> > This patch adds RTC support to the omap3 based beagleboard
> 
> I've pushed this after tweaking it manually again. It seems it was for
> some older kernel? Also you should check your mail client or smtp server
> to make sure patches don't wrap like this one is wrapped. It makes it
> hard to read and apply them.

maybe

$ git send-email --from "Koen Kooi <koen@openembedded.org>" --to linux-omap@vger.kernel.org file.patch

is enough. At least it doesn't wrap lines ;-)

just set

$ git config --global sendemail.smtpserver mail.openembedded.org

or whatever you use as smtp server.

if you need auth:

$ git config --global sendemail.user <username>

recent versions of git will interactively ask password.

-- 
Best Regards,

Felipe Balbi
me@felipebalbi.com
http://blog.felipebalbi.com

^ permalink raw reply	[flat|nested] 4+ messages in thread

* Re: [Resend] [PATCH] ARM: OMAP: add RTC support to beagleboard
  2008-05-14 22:56   ` Felipe Balbi
@ 2008-05-15  6:41     ` Koen Kooi
  0 siblings, 0 replies; 4+ messages in thread
From: Koen Kooi @ 2008-05-15  6:41 UTC (permalink / raw)
  To: me; +Cc: linux-omap

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1


Op 15 mei 2008, om 00:56 heeft Felipe Balbi het volgende geschreven:
> On Wed, May 14, 2008 at 03:42:53PM -0700, Tony Lindgren wrote:
>> * Koen Kooi <k.kooi@student.utwente.nl> [080513 01:20]:
>>> This patch adds RTC support to the omap3 based beagleboard
>>
>> I've pushed this after tweaking it manually again. It seems it was  
>> for
>> some older kernel? Also you should check your mail client or smtp  
>> server
>> to make sure patches don't wrap like this one is wrapped. It makes it
>> hard to read and apply them.
>
> maybe
>
> $ git send-email --from "Koen Kooi <koen@openembedded.org>" --to linux-omap@vger.kernel.org 
>  file.patch
>
> is enough. At least it doesn't wrap lines ;-)
>
> just set
>
> $ git config --global sendemail.smtpserver mail.openembedded.org
>
> or whatever you use as smtp server.
>
> if you need auth:
>
> $ git config --global sendemail.user <username>
>
> recent versions of git will interactively ask password.

I'll try that next time, thanks.

regards,

Koen



>
>
> -- 
> Best Regards,
>
> Felipe Balbi
> me@felipebalbi.com
> http://blog.felipebalbi.com
> --
> To unsubscribe from this list: send the line "unsubscribe linux- 
> omap" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at  http://vger.kernel.org/majordomo-info.html
>

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.5 (Darwin)

iD8DBQFIK9sHMkyGM64RGpERAsiCAKCFPIfjKZ+8zE9PpAZngf2B83Y7cQCfTmcs
uhCshhlj574ZKUCaTtmh2VY=
=fQtT
-----END PGP SIGNATURE-----

^ permalink raw reply	[flat|nested] 4+ messages in thread

end of thread, other threads:[~2008-05-15  6:41 UTC | newest]

Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2008-05-13  8:17 [Resend] [PATCH] ARM: OMAP: add RTC support to beagleboard Koen Kooi
2008-05-14 22:42 ` Tony Lindgren
2008-05-14 22:56   ` Felipe Balbi
2008-05-15  6:41     ` Koen Kooi

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.