From: Stephen Hemminger <shemminger@vyatta.com>
To: Jeff Garzik <jgarzik@pobox.com>
Cc: netdev@vger.kernel.org
Subject: [PATCH 2/5] sky2: don't warn if page allocation fails
Date: Wed, 14 May 2008 17:04:14 -0700 [thread overview]
Message-ID: <20080515000432.989061538@vyatta.com> (raw)
In-Reply-To: 20080515000412.984337700@vyatta.com
[-- Attachment #1: sky2-nowarn-alloc-page.patch --]
[-- Type: text/plain, Size: 662 bytes --]
Since driver handles page allocation failure, no need for extra
warnings.
Note: it only allocates single pages so if the system is
so tight it can't one page it is probably hosed anyway.
Signed-off-by: Stephen Hemminger <shemminger@vyatta.com>
---
Please apply to 2.6.26
--- a/drivers/net/sky2.c 2008-05-14 16:29:39.000000000 -0700
+++ b/drivers/net/sky2.c 2008-05-14 16:29:44.000000000 -0700
@@ -1223,7 +1223,7 @@ static struct sk_buff *sky2_rx_alloc(str
}
for (i = 0; i < sky2->rx_nfrags; i++) {
- struct page *page = alloc_page(GFP_ATOMIC);
+ struct page *page = alloc_page(GFP_ATOMIC | __GFP_NOWARN);
if (!page)
goto free_partial;
--
next prev parent reply other threads:[~2008-05-15 0:08 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-05-15 0:04 [PATCH 0/5] sky2: driver update Stephen Hemminger
2008-05-15 0:04 ` [PATCH 1/5] sky2: restore vlan acceleration on reset Stephen Hemminger
2008-05-21 17:02 ` Stephen Hemminger
2008-05-21 17:12 ` Jeff Garzik
2008-05-22 10:01 ` Jeff Garzik
2008-05-15 0:04 ` Stephen Hemminger [this message]
2008-05-22 9:57 ` [PATCH 2/5] sky2: don't warn if page allocation fails Jeff Garzik
2008-05-27 18:47 ` Stephen Hemminger
2008-06-03 6:16 ` Nick Piggin
2008-05-15 0:04 ` [PATCH 3/5] sky2: split phy power into two functions Stephen Hemminger
2008-05-31 2:20 ` Jeff Garzik
2008-05-15 0:04 ` [PATCH 4/5] sky2: put PHY in sleep when down Stephen Hemminger
2008-05-15 0:04 ` [PATCH 5/5] sky2: pci power savings Stephen Hemminger
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20080515000432.989061538@vyatta.com \
--to=shemminger@vyatta.com \
--cc=jgarzik@pobox.com \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.