Re: [uml-devel] [PATCH] make quiet suppress parse_chan_pair boot messages

[Rob Landley <rob@landley.net>]

On Friday 09 May 2008 10:22:17 Jeff Dike wrote:
> On Sat, May 03, 2008 at 03:18:10PM -0500, Rob Landley wrote:
> > I usually use UML as a better fakeroot, meaning I run it with a command
> > line like "rootfstype=hostfs rw quiet
> > init=/path/to/some_shell_script.sh".  In this context, filling the screen
> > with parse_chan_pair error messages which don't actually hurt anything
> > defeats the purpose of "quiet".
> >
> > The patch turns several KERN_ERR into KERN_WARNING.  While I was there, I
> > merged the redundant printk() statements into a function, and added one
> > "else" after a test-for-null that did a printk but didn't do a continue.
>
> Looks reasonable.

Do I have to do anything to follow up, or is it queued to go upstream?  (I can 
redo the printk() with pr_warning(), it's just the original didn't and I 
didn't change it...)

Rob
-- 
"One of my most productive days was throwing away 1000 lines of code."
  - Ken Thompson.

-------------------------------------------------------------------------
This SF.net email is sponsored by: Microsoft 
Defy all challenges. Microsoft(R) Visual Studio 2008. 
http://clk.atdmt.com/MRT/go/vse0120000070mrt/direct/01/
_______________________________________________
User-mode-linux-devel mailing list
User-mode-linux-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/user-mode-linux-devel