From: Oleg Nesterov <oleg@tv-sign.ru>
To: Andrew Morton <akpm@linux-foundation.org>
Cc: Austin Clements <amdragon+kernelbugzilla@mit.edu>,
Ingo Molnar <mingo@elte.hu>, john stultz <johnstul@us.ibm.com>,
Linus Torvalds <torvalds@linux-foundation.org>,
Michael Kerrisk <mtk.manpages@googlemail.com>,
Roland McGrath <roland@redhat.com>,
Thomas Gleixner <tglx@linutronix.de>,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH 3/3] posix timers: use SIGQUEUE_CANCELLED when the timer is destroyed
Date: Sat, 17 May 2008 19:31:40 +0400 [thread overview]
Message-ID: <20080517153140.GA9534@tv-sign.ru> (raw)
In-Reply-To: <20080517151422.GA9502@tv-sign.ru>
On 05/17, Oleg Nesterov wrote:
>
> This is a user visible change. With this patch sys_timer_delete() discards
> the pending signal which was generated by the timer.
If this change is undesirable, we can (for example) do
--- kernel/posix-timers.c
+++ kernel/posix-timers.c
@@ -885,6 +885,7 @@ itimer_delete(struct k_itimer *timer)
timer->it_process = NULL;
unlock_timer(timer, flags);
+ tmr->sigq->flags |= SIGQUEUE_CANCELLED;
release_posix_timer(timer, IT_ID_SET);
}
instead, and still fix the "BUG 10460".
Oleg.
next prev parent reply other threads:[~2008-05-17 15:31 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-05-17 15:14 [PATCH 3/3] posix timers: use SIGQUEUE_CANCELLED when the timer is destroyed Oleg Nesterov
2008-05-17 15:31 ` Oleg Nesterov [this message]
2008-05-17 17:11 ` Linus Torvalds
2008-05-18 17:15 ` Oleg Nesterov
2008-05-18 17:24 ` Linus Torvalds
2008-05-18 17:40 ` Linus Torvalds
2008-05-18 17:46 ` Oleg Nesterov
2008-05-21 2:27 ` Roland McGrath
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20080517153140.GA9534@tv-sign.ru \
--to=oleg@tv-sign.ru \
--cc=akpm@linux-foundation.org \
--cc=amdragon+kernelbugzilla@mit.edu \
--cc=johnstul@us.ibm.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@elte.hu \
--cc=mtk.manpages@googlemail.com \
--cc=roland@redhat.com \
--cc=tglx@linutronix.de \
--cc=torvalds@linux-foundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.