All of lore.kernel.org
 help / color / mirror / Atom feed
From: Rusty Russell <rusty@rustcorp.com.au>
To: David Miller <davem@davemloft.net>
Cc: herbert@gondor.apana.org.au, mb@bu3sch.de,
	johannes@sipsolutions.net, linux-wireless@vger.kernel.org,
	netdev@vger.kernel.org, ron.rindjunsky@intel.com,
	tomasw@gmail.com, ivdoorn@gmail.com,
	peter.p.waskiewicz.jr@intel.com
Subject: Re: [PATCH] mac80211: rewrite fragmentation code
Date: Mon, 19 May 2008 13:08:13 +1000	[thread overview]
Message-ID: <200805191308.14548.rusty@rustcorp.com.au> (raw)
In-Reply-To: <20080516.124039.253626477.davem@davemloft.net>

On Saturday 17 May 2008 05:40:39 David Miller wrote:
> My description describes how I want the mid-layer queue to disappear
> entirely.  Queueing would be done by the driver only.

Ok, the more I ponder this, the more I like it.  It has a very nice side 
benefit for virtio_net: we can xmit a whole bunch of packets before notifying 
the host.  Real NICs might gain similarly.

The bit I can't see is what to do about qdisc if the driver manages its own 
queue(s).  Leave the qdisc as currently in place and have the driver call 
dev_dequeue_skb() (or some wrapper) directly?  Modulo locking issues, that 
should be a fairly simple change.

Thanks,
Rusty.

WARNING: multiple messages have this Message-ID (diff)
From: Rusty Russell <rusty-8n+1lVoiYb80n/F98K4Iww@public.gmane.org>
To: David Miller <davem-fT/PcQaiUtIeIZ0/mPfg9Q@public.gmane.org>
Cc: herbert-lOAM2aK0SrRLBo1qDEOMRrpzq4S04n8Q@public.gmane.org,
	mb-fseUSCV1ubazQB+pC5nmwQ@public.gmane.org,
	johannes-cdvu00un1VgdHxzADdlk8Q@public.gmane.org,
	linux-wireless-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
	netdev-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
	ron.rindjunsky-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org,
	tomasw-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org,
	ivdoorn-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org,
	peter.p.waskiewicz.jr-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org
Subject: Re: [PATCH] mac80211: rewrite fragmentation code
Date: Mon, 19 May 2008 13:08:13 +1000	[thread overview]
Message-ID: <200805191308.14548.rusty@rustcorp.com.au> (raw)
In-Reply-To: <20080516.124039.253626477.davem-fT/PcQaiUtIeIZ0/mPfg9Q@public.gmane.org>

On Saturday 17 May 2008 05:40:39 David Miller wrote:
> My description describes how I want the mid-layer queue to disappear
> entirely.  Queueing would be done by the driver only.

Ok, the more I ponder this, the more I like it.  It has a very nice side 
benefit for virtio_net: we can xmit a whole bunch of packets before notifying 
the host.  Real NICs might gain similarly.

The bit I can't see is what to do about qdisc if the driver manages its own 
queue(s).  Leave the qdisc as currently in place and have the driver call 
dev_dequeue_skb() (or some wrapper) directly?  Modulo locking issues, that 
should be a fairly simple change.

Thanks,
Rusty.
--
To unsubscribe from this list: send the line "unsubscribe linux-wireless" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

  reply	other threads:[~2008-05-19  6:35 UTC|newest]

Thread overview: 69+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-04-30 12:40 [RFC/RFT 0/4] mac80211 QoS-related enhancements Johannes Berg
2008-04-30 12:40 ` [RFC/RFT 1/4] mac80211: use rate index in TX control Johannes Berg
2008-04-30 12:40   ` Johannes Berg
2008-04-30 12:40 ` [RFC/RFT 2/4] GSO: generalize for mac80211 Johannes Berg
2008-04-30 12:40   ` Johannes Berg
2008-05-06 16:12   ` Johannes Berg
2008-05-06 16:12     ` Johannes Berg
2008-04-30 12:40 ` [RFC/RFT 3/4] mac80211: use GSO for fragmentation Johannes Berg
2008-04-30 12:40   ` Johannes Berg
2008-05-07  7:10   ` Herbert Xu
2008-05-07  8:50     ` Johannes Berg
2008-05-07  9:00       ` Herbert Xu
2008-05-07 11:22         ` [PATCH] mac80211: rewrite fragmentation code Johannes Berg
2008-05-07 11:22           ` Johannes Berg
2008-05-07 11:41           ` Herbert Xu
2008-05-07 11:41             ` Herbert Xu
2008-05-07 11:52             ` Johannes Berg
2008-05-07 13:05               ` Herbert Xu
2008-05-07 13:05                 ` Herbert Xu
2008-05-07 13:48                 ` Michael Buesch
2008-05-07 13:48                   ` Michael Buesch
2008-05-08  3:22                   ` Herbert Xu
2008-05-08  3:26                     ` David Miller
2008-05-08  3:26                       ` David Miller
2008-05-08  9:00                       ` Johannes Berg
2008-05-08  9:00                         ` Johannes Berg
2008-05-16  2:01                       ` Rusty Russell
2008-05-16  2:01                         ` Rusty Russell
2008-05-16  3:28                         ` Herbert Xu
2008-05-16  4:58                         ` David Miller
2008-05-16 10:32                           ` Rusty Russell
2008-05-16 10:32                             ` Rusty Russell
2008-05-16 10:38                             ` Johannes Berg
2008-05-16 10:38                               ` Johannes Berg
2008-05-16 12:15                             ` Herbert Xu
2008-05-16 19:40                             ` David Miller
2008-05-19  3:08                               ` Rusty Russell [this message]
2008-05-19  3:08                                 ` Rusty Russell
2008-05-19  7:03                                 ` David Miller
2008-05-08 13:00                     ` Michael Buesch
2008-05-08 13:08                       ` Herbert Xu
2008-05-08 13:08                         ` Herbert Xu
2008-05-08 13:13                         ` Michael Buesch
2008-05-08 13:15                           ` Michael Buesch
2008-05-08 13:32                           ` Herbert Xu
2008-05-08 13:32                             ` Herbert Xu
2008-05-07 19:19                 ` Johannes Berg
2008-05-07 19:19                   ` Johannes Berg
2008-04-30 12:40 ` [RFC/RFT 4/4] mac80211: use multi-queue master netdevice Johannes Berg
2008-04-30 12:40   ` Johannes Berg
2008-04-30 14:37   ` Ivo van Doorn
2008-04-30 14:37     ` Ivo van Doorn
2008-04-30 14:45     ` Johannes Berg
2008-04-30 14:45       ` Johannes Berg
2008-04-30 15:00       ` Johannes Berg
2008-04-30 15:00         ` Johannes Berg
2008-04-30 15:34         ` Ivo van Doorn
2008-04-30 15:34           ` Ivo van Doorn
2008-04-30 15:38           ` Johannes Berg
2008-05-01  8:21         ` Ivo van Doorn
2008-05-01  8:21           ` Ivo van Doorn
2008-05-01  8:54           ` Johannes Berg
2008-05-01  8:54             ` Johannes Berg
2008-04-30 19:39   ` Waskiewicz Jr, Peter P
2008-04-30 19:39     ` Waskiewicz Jr, Peter P
2008-04-30 20:07     ` Johannes Berg
2008-04-30 20:07       ` Johannes Berg
2008-04-30 13:07 ` [RFC/RFT 0/4] mac80211 QoS-related enhancements Johannes Berg
2008-04-30 20:59   ` Michael Buesch

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=200805191308.14548.rusty@rustcorp.com.au \
    --to=rusty@rustcorp.com.au \
    --cc=davem@davemloft.net \
    --cc=herbert@gondor.apana.org.au \
    --cc=ivdoorn@gmail.com \
    --cc=johannes@sipsolutions.net \
    --cc=linux-wireless@vger.kernel.org \
    --cc=mb@bu3sch.de \
    --cc=netdev@vger.kernel.org \
    --cc=peter.p.waskiewicz.jr@intel.com \
    --cc=ron.rindjunsky@intel.com \
    --cc=tomasw@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.