The second argument "type" is not used in audit_filter

All of lore.kernel.org
 help / color / mirror / Atom feed

* The second argument "type" is not used in audit_filter_user()
@ 2008-05-16  9:10 Peng Haitao
  2008-05-19 17:11 ` Steve Grubb
  0 siblings, 1 reply; 2+ messages in thread
From: Peng Haitao @ 2008-05-16  9:10 UTC (permalink / raw)
  To: sgrubb, dwmw2; +Cc: linux-audit

I find the second argument "type" is not used in audit_filter_user().
Is it used later or redundant?
If it is redundant, I think it should be removed.
 
-- 
Regards
Peng Haitao

^ permalink raw reply	[flat|nested] 2+ messages in thread

* Re: The second argument "type" is not used in audit_filter_user()
  2008-05-16  9:10 The second argument "type" is not used in audit_filter_user() Peng Haitao
@ 2008-05-19 17:11 ` Steve Grubb
  0 siblings, 0 replies; 2+ messages in thread
From: Steve Grubb @ 2008-05-19 17:11 UTC (permalink / raw)
  To: Peng Haitao; +Cc: linux-audit, dwmw2

On Friday 16 May 2008 05:10:11 am Peng Haitao wrote:
> I find the second argument "type" is not used in audit_filter_user().

I researched this all the way back to our RHEL4 kernel. This appears to be in 
every kernel I can find. I don't know what its original purpose is, but it 
does appear to be unused. Its not on a performance critical path, but should 
be cleaned up just on the principal of it. Someone should submit a patch 
deleting this argument.

-Steve

^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2008-05-19 17:11 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2008-05-16  9:10 The second argument "type" is not used in audit_filter_user() Peng Haitao
2008-05-19 17:11 ` Steve Grubb

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.