From: Andrew Morton <akpm@linux-foundation.org>
To: Herbert Xu <herbert@gondor.apana.org.au>
Cc: FUJITA Tomonori <fujita.tomonori@lab.ntt.co.jp>,
linux-scsi@vger.kernel.org, linux-ide@vger.kernel.org,
jens.axboe@oracle.com, tsbogend@alpha.franken.de,
bzolnier@gmail.com, James.Bottomley@HansenPartnership.com,
jeff@garzik.org, davem@davemloft.net, linux-mm@kvack.org
Subject: Re: [PATCH 1/4] block: use ARCH_KMALLOC_MINALIGN as the default dma pad mask
Date: Tue, 20 May 2008 02:52:31 -0700 [thread overview]
Message-ID: <20080520025231.b88bc71d.akpm@linux-foundation.org> (raw)
In-Reply-To: <20080520093819.GA9147@gondor.apana.org.au>
On Tue, 20 May 2008 17:38:20 +0800 Herbert Xu <herbert@gondor.apana.org.au> wrote:
> On Tue, May 20, 2008 at 02:31:29AM -0700, Andrew Morton wrote:
> >
> > So here you're using it for "dma aligment" whereas crypto is using it
> > (or ARCH_SLAB_MINALIGN!) for "cpu 64-bit alignment".
>
> No the 64-bit alignment is just an example. The purpose of
> CRYPTO_MINALIGN is pretty much the same as ARCH_KMALLOC_MINALIGN,
> i.e., the minimum alignment guaranteed by kmalloc. The only
> reason it exists is because ARCH_KMALLOC_MINALIGN isn't defined
> on all platforms.
I'm struggling to understand what you're saying here.
The comment you have there over the CRYPTO_MINALIGN definition is quite
specific. Is it wrong?
Whether the mapping between CRYPTO_MINALIGN and ARCH_KMALLOC_MINALIGN
is abusive is (I find) hard to say, because first one would need to be
able to say what ARCH_KMALLOC_MINALIGN is for. I expect it was for DMA
purposes.
WARNING: multiple messages have this Message-ID (diff)
From: Andrew Morton <akpm@linux-foundation.org>
To: Herbert Xu <herbert@gondor.apana.org.au>
Cc: FUJITA Tomonori <fujita.tomonori@lab.ntt.co.jp>,
linux-scsi@vger.kernel.org, linux-ide@vger.kernel.org,
jens.axboe@oracle.com, tsbogend@alpha.franken.de,
bzolnier@gmail.com, James.Bottomley@HansenPartnership.com,
jeff@garzik.org, davem@davemloft.net, linux-mm@kvack.org
Subject: Re: [PATCH 1/4] block: use ARCH_KMALLOC_MINALIGN as the default dma pad mask
Date: Tue, 20 May 2008 02:52:31 -0700 [thread overview]
Message-ID: <20080520025231.b88bc71d.akpm@linux-foundation.org> (raw)
In-Reply-To: <20080520093819.GA9147@gondor.apana.org.au>
On Tue, 20 May 2008 17:38:20 +0800 Herbert Xu <herbert@gondor.apana.org.au> wrote:
> On Tue, May 20, 2008 at 02:31:29AM -0700, Andrew Morton wrote:
> >
> > So here you're using it for "dma aligment" whereas crypto is using it
> > (or ARCH_SLAB_MINALIGN!) for "cpu 64-bit alignment".
>
> No the 64-bit alignment is just an example. The purpose of
> CRYPTO_MINALIGN is pretty much the same as ARCH_KMALLOC_MINALIGN,
> i.e., the minimum alignment guaranteed by kmalloc. The only
> reason it exists is because ARCH_KMALLOC_MINALIGN isn't defined
> on all platforms.
I'm struggling to understand what you're saying here.
The comment you have there over the CRYPTO_MINALIGN definition is quite
specific. Is it wrong?
Whether the mapping between CRYPTO_MINALIGN and ARCH_KMALLOC_MINALIGN
is abusive is (I find) hard to say, because first one would need to be
able to say what ARCH_KMALLOC_MINALIGN is for. I expect it was for DMA
purposes.
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
next prev parent reply other threads:[~2008-05-20 9:54 UTC|newest]
Thread overview: 74+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-05-20 4:58 [PATCH 0/4] revert the commit 22a9189f (cdrom: use kmalloced buffers instead of buffers on stack) FUJITA Tomonori
2008-05-20 4:58 ` [PATCH 1/4] block: use ARCH_KMALLOC_MINALIGN as the default dma pad mask FUJITA Tomonori
2008-05-20 4:58 ` [PATCH 2/4] block: add blk_queue_update_dma_pad FUJITA Tomonori
2008-05-20 4:58 ` [PATCH 3/4] ide: use the dma safe check for REQ_TYPE_ATA_PC FUJITA Tomonori
2008-05-20 4:58 ` [PATCH 4/4] cdrom: revert commit 22a9189 (cdrom: use kmalloced buffers instead of buffers on stack) FUJITA Tomonori
2008-05-20 7:33 ` Elias Oltmanns
2008-05-20 7:42 ` Jim Paris
2008-05-20 8:14 ` Elias Oltmanns
2008-05-28 6:43 ` [PATCH 3/4] ide: use the dma safe check for REQ_TYPE_ATA_PC Borislav Petkov
2008-05-20 9:31 ` [PATCH 1/4] block: use ARCH_KMALLOC_MINALIGN as the default dma pad mask Andrew Morton
2008-05-20 9:31 ` Andrew Morton
2008-05-20 9:38 ` Herbert Xu
2008-05-20 9:38 ` Herbert Xu
2008-05-20 9:52 ` Andrew Morton [this message]
2008-05-20 9:52 ` Andrew Morton
2008-05-20 9:58 ` FUJITA Tomonori
2008-05-20 9:58 ` FUJITA Tomonori
2008-05-20 11:32 ` Herbert Xu
2008-05-20 11:32 ` Herbert Xu
2008-05-20 13:25 ` FUJITA Tomonori
2008-05-20 13:25 ` FUJITA Tomonori
2008-05-20 15:34 ` Herbert Xu
2008-05-20 15:34 ` Herbert Xu
2008-05-20 15:53 ` Plans for libsas and SAS-2? Marushak, Nathan
2008-05-20 16:09 ` [PATCH 1/4] block: use ARCH_KMALLOC_MINALIGN as the default dma pad mask FUJITA Tomonori
2008-05-20 16:09 ` FUJITA Tomonori
2008-05-21 1:26 ` Herbert Xu
2008-05-21 1:26 ` Herbert Xu
2008-05-21 1:36 ` FUJITA Tomonori
2008-05-21 1:36 ` FUJITA Tomonori
2008-05-21 3:16 ` Herbert Xu
2008-05-21 3:16 ` Herbert Xu
2008-05-21 6:54 ` FUJITA Tomonori
2008-05-21 6:54 ` FUJITA Tomonori
2008-05-21 8:47 ` Herbert Xu
2008-05-21 8:47 ` Herbert Xu
2008-05-21 9:34 ` FUJITA Tomonori
2008-05-21 9:34 ` FUJITA Tomonori
2008-05-21 10:05 ` Herbert Xu
2008-05-21 10:05 ` Herbert Xu
2008-05-21 11:01 ` FUJITA Tomonori
2008-05-21 11:01 ` FUJITA Tomonori
2008-05-21 11:25 ` Herbert Xu
2008-05-21 11:25 ` Herbert Xu
2008-05-21 12:09 ` FUJITA Tomonori
2008-05-21 12:09 ` FUJITA Tomonori
2008-05-21 12:22 ` Herbert Xu
2008-05-21 12:22 ` Herbert Xu
2008-05-21 12:46 ` FUJITA Tomonori
2008-05-21 12:46 ` FUJITA Tomonori
2008-05-21 12:55 ` FUJITA Tomonori
2008-05-21 12:55 ` FUJITA Tomonori
2008-05-21 13:19 ` Herbert Xu
2008-05-21 13:19 ` Herbert Xu
2008-05-21 13:18 ` Herbert Xu
2008-05-21 13:18 ` Herbert Xu
2008-05-22 1:14 ` FUJITA Tomonori
2008-05-22 1:14 ` FUJITA Tomonori
2008-05-22 1:19 ` David Miller
2008-05-22 1:19 ` David Miller, FUJITA Tomonori
2008-05-22 1:21 ` Herbert Xu
2008-05-22 1:21 ` Herbert Xu
2008-05-22 1:32 ` FUJITA Tomonori
2008-05-22 1:32 ` FUJITA Tomonori
2008-05-22 1:56 ` Herbert Xu
2008-05-22 1:56 ` Herbert Xu
2008-05-20 9:55 ` Paul Mundt
2008-05-20 9:55 ` Paul Mundt
2008-05-21 22:11 ` [PATCH 0/4] revert the commit 22a9189f (cdrom: use kmalloced buffers instead of buffers on stack) Thomas Bogendoerfer
2008-05-22 1:13 ` FUJITA Tomonori
2008-05-22 1:18 ` David Miller
2008-05-22 8:43 ` James Bottomley
2008-05-26 9:17 ` FUJITA Tomonori
2008-05-27 18:58 ` Bartlomiej Zolnierkiewicz
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20080520025231.b88bc71d.akpm@linux-foundation.org \
--to=akpm@linux-foundation.org \
--cc=James.Bottomley@HansenPartnership.com \
--cc=bzolnier@gmail.com \
--cc=davem@davemloft.net \
--cc=fujita.tomonori@lab.ntt.co.jp \
--cc=herbert@gondor.apana.org.au \
--cc=jeff@garzik.org \
--cc=jens.axboe@oracle.com \
--cc=linux-ide@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=linux-scsi@vger.kernel.org \
--cc=tsbogend@alpha.franken.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.