All of lore.kernel.org
 help / color / mirror / Atom feed
From: "peerchen" <peerchen@gmail.com>
To: Jeff Garzik <jeff@garzik.org>
Cc: linux-kernel <linux-kernel@vger.kernel.org>,
	linux-ide <linux-ide@vger.kernel.org>,
	akpm <akpm@linux-foundation.org>
Subject: Re: Re: [PATCH] ahci: change the Device IDs of nvidia MCP7B AHCI controllerin ahci.c
Date: Tue, 20 May 2008 10:50:56 +0800	[thread overview]
Message-ID: <200805201050523570380@gmail.com> (raw)
In-Reply-To: 4831D0F8.4060706@garzik.org

We make a mistake, the IDs need to be changed are not correct, those IDs belong to other devices.

------------------				 
peerchen
2008-05-20

-------------------------------------------------------------
发件人:Jeff Garzik
发送日期:2008-05-20 03:11:56
收件人:peerchen
抄送:linux-kernel; linux-ide; akpm
主题:Re: [PATCH] ahci: change the Device IDs of nvidia MCP7B AHCI controllerin ahci.c

peerchen wrote:
> Change the partial Device IDs of nvidia MCP7B AHCI controller in ahci.c
> 
> Signed-off-by: Peer Chen <peerchen@gmail.com>
> ---
> --- linux-2.6.26-rc3/drivers/ata/ahci.c.orig	2008-05-07 13:24:19.000000000 -0400
> +++ linux-2.6.26-rc3/drivers/ata/ahci.c	2008-05-07 13:25:17.000000000 -0400
> @@ -502,10 +502,10 @@ static const struct pci_device_id ahci_p
>  	{ PCI_VDEVICE(NVIDIA, 0x0bcd), board_ahci },		/* MCP7B */
>  	{ PCI_VDEVICE(NVIDIA, 0x0bce), board_ahci },		/* MCP7B */
>  	{ PCI_VDEVICE(NVIDIA, 0x0bcf), board_ahci },		/* MCP7B */
> -	{ PCI_VDEVICE(NVIDIA, 0x0bd0), board_ahci },		/* MCP7B */
> -	{ PCI_VDEVICE(NVIDIA, 0x0bd1), board_ahci },		/* MCP7B */
> -	{ PCI_VDEVICE(NVIDIA, 0x0bd2), board_ahci },		/* MCP7B */
> -	{ PCI_VDEVICE(NVIDIA, 0x0bd3), board_ahci },		/* MCP7B */
> +	{ PCI_VDEVICE(NVIDIA, 0x0bc4), board_ahci },		/* MCP7B */
> +	{ PCI_VDEVICE(NVIDIA, 0x0bc5), board_ahci },		/* MCP7B */
> +	{ PCI_VDEVICE(NVIDIA, 0x0bc6), board_ahci },		/* MCP7B */
> +	{ PCI_VDEVICE(NVIDIA, 0x0bc7), board_ahci },		/* MCP7B */

A little bit more patch description, please?

Why is this change needed?  A change with a description of
(paraphrasing) "do this change" is rather vague ;)

	Jeff




WARNING: multiple messages have this Message-ID (diff)
From: "peerchen" <peerchen@gmail.com>
To: "Jeff Garzik" <jeff@garzik.org>
Cc: "linux-kernel" <linux-kernel@vger.kernel.org>,
	"linux-ide" <linux-ide@vger.kernel.org>,
	"akpm" <akpm@linux-foundation.org>
Subject: Re: Re: [PATCH] ahci: change the Device IDs of nvidia MCP7B AHCI controllerin ahci.c
Date: Tue, 20 May 2008 10:50:56 +0800	[thread overview]
Message-ID: <200805201050523570380@gmail.com> (raw)
In-Reply-To: 4831D0F8.4060706@garzik.org

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #1: Type: text/plain; charset="gb2312", Size: 1779 bytes --]

We make a mistake, the IDs need to be changed are not correct, those IDs belong to other devices.

------------------				 
peerchen
2008-05-20

-------------------------------------------------------------
·¢¼þÈË£ºJeff Garzik
·¢ËÍÈÕÆÚ£º2008-05-20 03:11:56
ÊÕ¼þÈË£ºpeerchen
³­ËÍ£ºlinux-kernel; linux-ide; akpm
Ö÷Ì⣺Re: [PATCH] ahci: change the Device IDs of nvidia MCP7B AHCI controllerin ahci.c

peerchen wrote:
> Change the partial Device IDs of nvidia MCP7B AHCI controller in ahci.c
> 
> Signed-off-by: Peer Chen <peerchen@gmail.com>
> ---
> --- linux-2.6.26-rc3/drivers/ata/ahci.c.orig	2008-05-07 13:24:19.000000000 -0400
> +++ linux-2.6.26-rc3/drivers/ata/ahci.c	2008-05-07 13:25:17.000000000 -0400
> @@ -502,10 +502,10 @@ static const struct pci_device_id ahci_p
>  	{ PCI_VDEVICE(NVIDIA, 0x0bcd), board_ahci },		/* MCP7B */
>  	{ PCI_VDEVICE(NVIDIA, 0x0bce), board_ahci },		/* MCP7B */
>  	{ PCI_VDEVICE(NVIDIA, 0x0bcf), board_ahci },		/* MCP7B */
> -	{ PCI_VDEVICE(NVIDIA, 0x0bd0), board_ahci },		/* MCP7B */
> -	{ PCI_VDEVICE(NVIDIA, 0x0bd1), board_ahci },		/* MCP7B */
> -	{ PCI_VDEVICE(NVIDIA, 0x0bd2), board_ahci },		/* MCP7B */
> -	{ PCI_VDEVICE(NVIDIA, 0x0bd3), board_ahci },		/* MCP7B */
> +	{ PCI_VDEVICE(NVIDIA, 0x0bc4), board_ahci },		/* MCP7B */
> +	{ PCI_VDEVICE(NVIDIA, 0x0bc5), board_ahci },		/* MCP7B */
> +	{ PCI_VDEVICE(NVIDIA, 0x0bc6), board_ahci },		/* MCP7B */
> +	{ PCI_VDEVICE(NVIDIA, 0x0bc7), board_ahci },		/* MCP7B */

A little bit more patch description, please?

Why is this change needed?  A change with a description of
(paraphrasing) "do this change" is rather vague ;)

	Jeff



ÿôèº{.nÇ+‰·Ÿ®‰­†+%ŠËÿ±éݶ\x17¥Šwÿº{.nÇ+‰·¥Š{±þG«éÿŠ{ayº\x1dʇڙë,j\a­¢f£¢·hšïêÿ‘êçz_è®\x03(­éšŽŠÝ¢j"ú\x1a¶^[m§ÿÿ¾\a«þG«éÿ¢¸?™¨è­Ú&£ø§~á¶iO•æ¬z·švØ^\x14\x04\x1a¶^[m§ÿÿÃ\fÿ¶ìÿ¢¸?–I¥

  reply	other threads:[~2008-05-20  2:51 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-05-19  6:44 [PATCH] ahci: change the Device IDs of nvidia MCP7B AHCI controller in ahci.c peerchen
2008-05-19 19:11 ` Jeff Garzik
2008-05-20  2:50   ` peerchen [this message]
2008-05-20  2:50     ` Re: [PATCH] ahci: change the Device IDs of nvidia MCP7B AHCI controllerin ahci.c peerchen
2008-05-30 22:11 ` [PATCH] ahci: change the Device IDs of nvidia MCP7B AHCI controller in ahci.c Jeff Garzik

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=200805201050523570380@gmail.com \
    --to=peerchen@gmail.com \
    --cc=akpm@linux-foundation.org \
    --cc=jeff@garzik.org \
    --cc=linux-ide@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.