Re: [PATCH] or51132.c: unaligned

[Al Viro <viro@ZenIV.linux.org.uk>]

On Tue, May 20, 2008 at 05:41:12PM -0700, Harvey Harrison wrote:

> > +	return buf[0] | (buf[1] << 8);
> 
> return get_unaligned_le16(buf);

And the point of that would be?

> > +	firmwareAsize = le32_to_cpu(*((__le32*)fw->data));
> 
> ???firmwareAsize = le32_to_cpup((__le32 *)fw->data);

... and the point of that would be?  FWIW, I really don't like the ...p()
forms - they are hard to distinguish from normal ones visually and any
possible performance benefit is too small for most of the uses.  IOW,
it's mostly redundant API.