From: Al Viro <viro@ZenIV.linux.org.uk>
To: Harvey Harrison <harvey.harrison@gmail.com>
Cc: Al Viro <viro@ftp.linux.org.uk>,
mchehab@infradead.org, linux-kernel@vger.kernel.org,
torvalds@linux-foundation.org, David Miller <davem@davemloft.net>
Subject: Re: [PATCH] or51132.c: unaligned
Date: Wed, 21 May 2008 01:56:57 +0100 [thread overview]
Message-ID: <20080521005657.GG28946@ZenIV.linux.org.uk> (raw)
In-Reply-To: <1211331088.5915.241.camel@brick>
On Tue, May 20, 2008 at 05:51:28PM -0700, Harvey Harrison wrote:
> > ... and the point of that would be? FWIW, I really don't like the ...p()
> > forms - they are hard to distinguish from normal ones visually and any
> > possible performance benefit is too small for most of the uses. IOW,
> > it's mostly redundant API.
>
> I sent a patchset getting rid of the p variants earlier today, Dave
> Miller made a good point that some arches have well optimized versions
> of these as they have specific machine instructions they can use.
Thus the "mostly" part - on hot paths the microoptimization is worth the
trouble. None of the places in question is on such paths...
next prev parent reply other threads:[~2008-05-21 0:57 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-05-21 0:33 [PATCH] or51132.c: unaligned Al Viro
2008-05-21 0:41 ` Harvey Harrison
2008-05-21 0:45 ` Al Viro
2008-05-21 0:51 ` Harvey Harrison
2008-05-21 0:56 ` Al Viro [this message]
2008-05-21 0:55 ` Linus Torvalds
2008-05-21 1:18 ` Al Viro
2008-05-21 2:02 ` Linus Torvalds
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20080521005657.GG28946@ZenIV.linux.org.uk \
--to=viro@zeniv.linux.org.uk \
--cc=davem@davemloft.net \
--cc=harvey.harrison@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mchehab@infradead.org \
--cc=torvalds@linux-foundation.org \
--cc=viro@ftp.linux.org.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.