From: "John W. Linville" <linville@tuxdriver.com>
To: Tomas Winkler <tomasw@gmail.com>
Cc: Helmut Schaa <hschaa@suse.de>,
Johannes Berg <johannes@sipsolutions.net>,
Larry Finger <Larry.Finger@lwfinger.net>,
linux-wireless@vger.kernel.org,
Bruno Randolf <bruno@thinktube.com>
Subject: Re: [PATCHv5] mac80211: fix NULL pointer dereference in ieee80211_compatible_rates
Date: Wed, 21 May 2008 09:54:51 -0400 [thread overview]
Message-ID: <20080521135451.GA3545@tuxdriver.com> (raw)
In-Reply-To: <1ba2fa240805210347w375b571djc922f814fa9f521f@mail.gmail.com>
On Wed, May 21, 2008 at 01:47:04PM +0300, Tomas Winkler wrote:
> On Tue, May 20, 2008 at 3:54 PM, Tomas Winkler <tomasw@gmail.com> wrote:
> > I found one ieee80211_rx_bss_{get,put} imbalance in
> > ieee80211_sta_join_ibss function
> > That may cause this problem yet it doesn't look like this is the case.
> > ieee80211_sta_join_ibss
> > calls ieee80211_rx_bss_put on 'bss' that it receives as an argument
>
> The patch below introduced _get/_put imbalance. ieee80211_rx_bss_info
> _put bss back at the end. Other callers of the ieee80211_sta_join_ibss
> function don't use put.
> I will post a patch that takes out the _put out of
> ieee80211_rx_bss_info, I think it's more readable.
Since you are doing _get and _add in ieee80211_rx_bss_info, it makes
sense to me to do _put at the end of it. Perhaps we should remove
the _put from the end of ieee80211_sta_join_ibss and change it's
callers instead?
John
--
John W. Linville
linville@tuxdriver.com
next prev parent reply other threads:[~2008-05-21 14:29 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-05-20 7:56 [PATCHv5] mac80211: fix NULL pointer dereference in ieee80211_compatible_rates Helmut Schaa
2008-05-20 12:54 ` Tomas Winkler
2008-05-20 12:57 ` Johannes Berg
2008-05-20 13:11 ` Tomas Winkler
2008-05-20 13:22 ` Johannes Berg
2008-05-20 13:33 ` Tomas Winkler
2008-05-20 13:38 ` Johannes Berg
2008-05-20 13:44 ` Tomas Winkler
2008-05-20 13:47 ` Larry Finger
2008-05-20 14:20 ` John W. Linville
2008-05-20 14:41 ` Tomas Winkler
2008-05-21 10:47 ` Tomas Winkler
2008-05-21 13:54 ` John W. Linville [this message]
2008-05-21 14:50 ` Tomas Winkler
2008-05-21 15:08 ` Johannes Berg
2008-05-21 15:11 ` Tomas Winkler
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20080521135451.GA3545@tuxdriver.com \
--to=linville@tuxdriver.com \
--cc=Larry.Finger@lwfinger.net \
--cc=bruno@thinktube.com \
--cc=hschaa@suse.de \
--cc=johannes@sipsolutions.net \
--cc=linux-wireless@vger.kernel.org \
--cc=tomasw@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.