All of lore.kernel.org
 help / color / mirror / Atom feed
From: Tony Lindgren <tony-4v6yS6AI5VpBDgjK7y7TUQ@public.gmane.org>
To: Bryan Wu <cooloney-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org>
Cc: Felipe Balbi <me-uiRdBs8odbtmTBlB0Cgj/Q@public.gmane.org>,
	David Brownell <david-b-yBeKhBN/0LDR7s880joybQ@public.gmane.org>,
	linux-omap-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
	linux-usb-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
	linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
Subject: Re: [PATCH 0/2] MUSB: 2 patches to fix some bug found on Blackfin
Date: Wed, 21 May 2008 08:50:03 -0700	[thread overview]
Message-ID: <20080521155003.GZ23002@atomide.com> (raw)
In-Reply-To: <386072610805190105y6618dd9bwe32503c1ae11b865-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>

* Bryan Wu <cooloney-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org> [080519 01:06]:
> On Mon, May 19, 2008 at 3:49 PM, Felipe Balbi <me-uiRdBs8odbtmTBlB0Cgj/Q@public.gmane.org> wrote:
> >
> >
> > On Mon, 19 May 2008 14:39:10 +0800, "Bryan Wu" <cooloney-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org> wrote:
> >> On Sat, May 17, 2008 at 10:37 PM, David Brownell <david-b-yBeKhBN/0LDR7s880joybQ@public.gmane.org>
> >> wrote:
> >>> On Saturday 17 May 2008, Bryan Wu wrote:
> >>>>
> >>>> We discussed these 4 bugs before. Now we fixed them.
> >>>> Please review following 2 patches.
> >>>
> >>> They looked plausible to me ... though the urb->status
> >>> one is a bit of a band-aid, and when that field finally
> >>> vanishes a better fix will be needed.
> >>>
> >>

I'll push these to linux-omap tree then.

> >> OK, so is there any plan for merge the MUSB to mainline and finally to
> >> remove the urb->status?
> >
> > I was planing to do this by the end of this year or as soon as I make all
> > usb if tests pass again. I'm out of tools for that right now :-s
> >
> 
> Great, after I enable the DMA mode 1 on Blackfin and cleanup the code,
> I will send
> out the code before you sent them to upstream

Maybe we should get the musb code to USB tree before that? It's been out
of the scope for linux-omap tree for quite a while now.

Tony
--
To unsubscribe from this list: send the line "unsubscribe linux-usb" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

WARNING: multiple messages have this Message-ID (diff)
From: Tony Lindgren <tony@atomide.com>
To: Bryan Wu <cooloney@kernel.org>
Cc: Felipe Balbi <me@felipebalbi.com>,
	David Brownell <david-b@pacbell.net>,
	linux-omap@vger.kernel.org, linux-usb@vger.kernel.org,
	linux-kernel@vger.kernel.org
Subject: Re: [PATCH 0/2] MUSB: 2 patches to fix some bug found on Blackfin
Date: Wed, 21 May 2008 08:50:03 -0700	[thread overview]
Message-ID: <20080521155003.GZ23002@atomide.com> (raw)
In-Reply-To: <386072610805190105y6618dd9bwe32503c1ae11b865@mail.gmail.com>

* Bryan Wu <cooloney@kernel.org> [080519 01:06]:
> On Mon, May 19, 2008 at 3:49 PM, Felipe Balbi <me@felipebalbi.com> wrote:
> >
> >
> > On Mon, 19 May 2008 14:39:10 +0800, "Bryan Wu" <cooloney@kernel.org> wrote:
> >> On Sat, May 17, 2008 at 10:37 PM, David Brownell <david-b@pacbell.net>
> >> wrote:
> >>> On Saturday 17 May 2008, Bryan Wu wrote:
> >>>>
> >>>> We discussed these 4 bugs before. Now we fixed them.
> >>>> Please review following 2 patches.
> >>>
> >>> They looked plausible to me ... though the urb->status
> >>> one is a bit of a band-aid, and when that field finally
> >>> vanishes a better fix will be needed.
> >>>
> >>

I'll push these to linux-omap tree then.

> >> OK, so is there any plan for merge the MUSB to mainline and finally to
> >> remove the urb->status?
> >
> > I was planing to do this by the end of this year or as soon as I make all
> > usb if tests pass again. I'm out of tools for that right now :-s
> >
> 
> Great, after I enable the DMA mode 1 on Blackfin and cleanup the code,
> I will send
> out the code before you sent them to upstream

Maybe we should get the musb code to USB tree before that? It's been out
of the scope for linux-omap tree for quite a while now.

Tony

  parent reply	other threads:[~2008-05-21 15:50 UTC|newest]

Thread overview: 21+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-05-17 11:01 [PATCH 0/2] MUSB: 2 patches to fix some bug found on Blackfin Bryan Wu
     [not found] ` <1211022081-27298-1-git-send-email-cooloney-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org>
2008-05-17 11:01   ` [PATCH 1/2] MUSB: fix bug - since 2.6.24 urb API changed, giveback function return wrong status Bryan Wu
2008-05-17 11:01     ` Bryan Wu
2008-05-17 11:01 ` [PATCH 2/2] MUSB: Real fix bug 4 usb bugs found on Blackfin Bryan Wu
2008-05-19 15:16   ` Gadiyar, Anand
2008-05-19 15:28     ` Mike Frysinger
2008-05-17 14:37 ` [PATCH 0/2] MUSB: 2 patches to fix some bug " David Brownell
2008-05-19  6:39   ` Bryan Wu
     [not found]     ` <386072610805182339n2e141b83q4b8f9804194088e4-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2008-05-19  7:49       ` Felipe Balbi
2008-05-19  7:49         ` Felipe Balbi
     [not found]         ` <71636ee466dd53c366eb11d8fc981e8b-uiRdBs8odbtmTBlB0Cgj/Q@public.gmane.org>
2008-05-19  8:05           ` Bryan Wu
2008-05-19  8:05             ` Bryan Wu
     [not found]             ` <386072610805190105y6618dd9bwe32503c1ae11b865-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2008-05-21 15:50               ` Tony Lindgren [this message]
2008-05-21 15:50                 ` Tony Lindgren
     [not found]                 ` <20080521155003.GZ23002-4v6yS6AI5VpBDgjK7y7TUQ@public.gmane.org>
2008-05-21 17:14                   ` David Brownell
2008-05-21 17:14                     ` David Brownell
2008-05-21 19:06                     ` Felipe Balbi
     [not found]                       ` <61cdb2dcc22913ddefddd7b4a6faede3-uiRdBs8odbtmTBlB0Cgj/Q@public.gmane.org>
2008-05-21 20:04                         ` David Brownell
2008-05-21 20:04                           ` David Brownell
     [not found]                           ` <200805211304.53082.david-b-yBeKhBN/0LDR7s880joybQ@public.gmane.org>
2008-05-21 20:10                             ` Mike Frysinger
2008-05-21 20:10                               ` Mike Frysinger

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20080521155003.GZ23002@atomide.com \
    --to=tony-4v6ys6ai5vpbdgjk7y7tuq@public.gmane.org \
    --cc=cooloney-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org \
    --cc=david-b-yBeKhBN/0LDR7s880joybQ@public.gmane.org \
    --cc=linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
    --cc=linux-omap-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
    --cc=linux-usb-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
    --cc=me-uiRdBs8odbtmTBlB0Cgj/Q@public.gmane.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.