From: Paul Brook <paul@codesourcery.com>
To: qemu-devel@nongnu.org
Cc: Anthony Liguori <aliguori@us.ibm.com>
Subject: Re: [Qemu-devel] [PATCH] Don't require GCC3 unless necessary (v2)
Date: Thu, 22 May 2008 14:20:17 +0100 [thread overview]
Message-ID: <200805221420.19520.paul@codesourcery.com> (raw)
In-Reply-To: <1211404888-29146-1-git-send-email-aliguori@us.ibm.com>
> +# Check if any targets require dyngen
> +for target in $target_list; do
You've just duplicated this logic. Please don't.
Paul
next prev parent reply other threads:[~2008-05-22 13:20 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-05-21 21:21 [Qemu-devel] [PATCH] Don't require GCC3 unless necessary (v2) Anthony Liguori
2008-05-22 13:20 ` Paul Brook [this message]
2008-05-22 16:22 ` Anthony Liguori
2008-05-22 16:31 ` Paul Brook
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=200805221420.19520.paul@codesourcery.com \
--to=paul@codesourcery.com \
--cc=aliguori@us.ibm.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.