All of lore.kernel.org
 help / color / mirror / Atom feed
From: Anthony Liguori <aliguori@us.ibm.com>
To: Paul Brook <paul@codesourcery.com>
Cc: qemu-devel@nongnu.org
Subject: Re: [Qemu-devel] [PATCH] Don't require GCC3 unless necessary (v2)
Date: Thu, 22 May 2008 11:22:56 -0500	[thread overview]
Message-ID: <48359DE0.9070807@us.ibm.com> (raw)
In-Reply-To: <200805221420.19520.paul@codesourcery.com>

Paul Brook wrote:
>> +# Check if any targets require dyngen
>> +for target in $target_list; do
>>     
>
> You've just duplicated this logic. Please don't.
>   

The problem is the dyngen checks have to be done before the use of $cc 
which is long before the target_list loop.  In the absence of 
introducing functions in the configure script (which aren't there right 
now), I don't see a good way to avoid the duplication.

The duplication is small and it's temporary until all targets convert to 
TCG.

Regards,

Anthony Liguori

> Paul
>   

  reply	other threads:[~2008-05-22 16:23 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-05-21 21:21 [Qemu-devel] [PATCH] Don't require GCC3 unless necessary (v2) Anthony Liguori
2008-05-22 13:20 ` Paul Brook
2008-05-22 16:22   ` Anthony Liguori [this message]
2008-05-22 16:31     ` Paul Brook

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=48359DE0.9070807@us.ibm.com \
    --to=aliguori@us.ibm.com \
    --cc=paul@codesourcery.com \
    --cc=qemu-devel@nongnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.