All of lore.kernel.org
 help / color / mirror / Atom feed
From: Rusty Russell <rusty@rustcorp.com.au>
To: Jens Axboe <jens.axboe@oracle.com>
Cc: Chris Lalancette <clalance@redhat.com>,
	virtualization@lists.linux-foundation.org, kvm@vger.kernel.org
Subject: Re: [Fwd: [PATCH]: Fix crash in virtio_blk during modprobe ; rmmod ; modprobe]
Date: Fri, 23 May 2008 11:16:07 +1000	[thread overview]
Message-ID: <200805231116.07773.rusty@rustcorp.com.au> (raw)
In-Reply-To: <20080522113517.GC7712@kernel.dk>

On Thursday 22 May 2008 21:35:19 Jens Axboe wrote:
> On Thu, May 22 2008, Rusty Russell wrote:
> > Thanks Chris, it seems reasonable and I'm sure it works (kinda hard to
> > test here, it's my root block dev).  Other drivers seem to do
> > blk_cleanup_queue() *after* del_gendisk: does it matter?
> >
> > Jens CC'd: he's gentle with my dumb questions...  Rusty.
>
> del_gendisk() can generate IO, so it would seem safer to do that
> _before_ putting the queue reference :-)

Thanks Jens.  Chris, I've fixed that up here.

Cheers,
Rusty.

  parent reply	other threads:[~2008-05-23  1:16 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-05-21 13:12 [Fwd: [PATCH]: Fix crash in virtio_blk during modprobe ; rmmod ; modprobe] Chris Lalancette
2008-05-22 11:33 ` Rusty Russell
2008-05-22 11:33 ` Rusty Russell
2008-05-22 11:35   ` Jens Axboe
2008-05-22 12:03     ` Chris Lalancette
2008-05-22 12:07       ` Jens Axboe
2008-05-22 12:07       ` Jens Axboe
2008-05-22 12:03     ` Chris Lalancette
2008-05-23  1:16     ` Rusty Russell
2008-05-23  1:16     ` Rusty Russell [this message]
2008-05-22 11:35   ` Jens Axboe

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=200805231116.07773.rusty@rustcorp.com.au \
    --to=rusty@rustcorp.com.au \
    --cc=clalance@redhat.com \
    --cc=jens.axboe@oracle.com \
    --cc=kvm@vger.kernel.org \
    --cc=virtualization@lists.linux-foundation.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.