[Fwd: [PATCH]: Fix crash in virtio_blk during modprobe ; rmmod ; modprobe]

From: Chris Lalancette <clalance@redhat.com>
To: virtualization@lists.linux-foundation.org
Cc: kvm@vger.kernel.org
Subject: [Fwd: [PATCH]: Fix crash in virtio_blk during modprobe ; rmmod ; modprobe]
Date: Wed, 21 May 2008 15:12:39 +0200	[thread overview]
Message-ID: <48341FC7.4060600@redhat.com> (raw)

[-- Attachment #1: Type: text/plain, Size: 49 bytes --]

(sent to the kvm mailing list erroneously first)

[-- Attachment #2: [PATCH]: Fix crash in virtio_blk during modprobe ; rmmod ; modprobe.eml --]
[-- Type: message/rfc822, Size: 4125 bytes --]

[-- Attachment #2.1.1: Type: text/plain, Size: 209 bytes --]

Fix a modprobe virtio_blk ; rmmod virtio_blk ; modprobe virtio_blk crash; this
was basically because we weren't doing "del_gendisk()" in the remove path.

Signed-off-by: Chris Lalancette <clalance@redhat.com>

[-- Attachment #2.1.2: virtio-blk-rmmod-crash.patch --]
[-- Type: text/x-patch, Size: 734 bytes --]

commit 9ae82ccb26be0155ad81b2630090e85639a0dc56
Author: Chris Lalancette <clalance@redhat.com>
Date:   Fri May 16 15:31:06 2008 -0400

    Fix a modprobe virtio_blk ; rmmod virtio_blk ; modprobe virtio_blk crash;
    this was basically because we weren't doing "del_gendisk()" in the remove
    path.

diff --git a/drivers/block/virtio_blk.c b/drivers/block/virtio_blk.c
index 4962e62..c678ac5 100644
--- a/drivers/block/virtio_blk.c
+++ b/drivers/block/virtio_blk.c
@@ -294,6 +294,7 @@ static void virtblk_remove(struct virtio_device *vdev)
 	vdev->config->reset(vdev);
 
 	blk_cleanup_queue(vblk->disk->queue);
+	del_gendisk(vblk->disk);
 	put_disk(vblk->disk);
 	unregister_blkdev(major, "virtblk");
 	mempool_destroy(vblk->pool);

[-- Attachment #3: Type: text/plain, Size: 184 bytes --]

_______________________________________________
Virtualization mailing list
Virtualization@lists.linux-foundation.org
https://lists.linux-foundation.org/mailman/listinfo/virtualization
