From: "Paul E. McKenney" <paulmck@linux.vnet.ibm.com>
To: Steven Rostedt <rostedt@goodmis.org>
Cc: linuxppc-dev@ozlabs.org, Ingo Molnar <mingo@elte.hu>,
paulus@samba.org, LKML <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] rcupreempt: remove export of rcu_batches_completed_bh
Date: Fri, 23 May 2008 07:14:03 -0700 [thread overview]
Message-ID: <20080523141403.GA8798@linux.vnet.ibm.com> (raw)
In-Reply-To: <Pine.LNX.4.58.0805221415330.14724@gandalf.stny.rr.com>
On Thu, May 22, 2008 at 02:18:17PM -0400, Steven Rostedt wrote:
>
> In rcupreempt, rcu_batches_completed_bh is defined as a static inline in
> the header file. This does not need to be exported, and not only that,
> this breaks my PPC build.
Good catch!!!
Reviewed-by: Paul E. McKenney <paulmck@linux.vnet.ibm.com>
> Signed-off-by: Steven Rostedt <srostedt@redhat.com>
> ---
> kernel/rcupreempt.c | 2 --
> 1 file changed, 2 deletions(-)
>
> Index: linux-tip.git/kernel/rcupreempt.c
> ===================================================================
> --- linux-tip.git.orig/kernel/rcupreempt.c 2008-05-22 11:12:30.000000000 -0700
> +++ linux-tip.git/kernel/rcupreempt.c 2008-05-22 11:12:33.000000000 -0700
> @@ -217,8 +217,6 @@ long rcu_batches_completed(void)
> }
> EXPORT_SYMBOL_GPL(rcu_batches_completed);
>
> -EXPORT_SYMBOL_GPL(rcu_batches_completed_bh);
> -
> void __rcu_read_lock(void)
> {
> int idx;
>
WARNING: multiple messages have this Message-ID (diff)
From: "Paul E. McKenney" <paulmck@linux.vnet.ibm.com>
To: Steven Rostedt <rostedt@goodmis.org>
Cc: LKML <linux-kernel@vger.kernel.org>, Ingo Molnar <mingo@elte.hu>,
paulus@samba.org, linuxppc-dev@ozlabs.org
Subject: Re: [PATCH] rcupreempt: remove export of rcu_batches_completed_bh
Date: Fri, 23 May 2008 07:14:03 -0700 [thread overview]
Message-ID: <20080523141403.GA8798@linux.vnet.ibm.com> (raw)
In-Reply-To: <Pine.LNX.4.58.0805221415330.14724@gandalf.stny.rr.com>
On Thu, May 22, 2008 at 02:18:17PM -0400, Steven Rostedt wrote:
>
> In rcupreempt, rcu_batches_completed_bh is defined as a static inline in
> the header file. This does not need to be exported, and not only that,
> this breaks my PPC build.
Good catch!!!
Reviewed-by: Paul E. McKenney <paulmck@linux.vnet.ibm.com>
> Signed-off-by: Steven Rostedt <srostedt@redhat.com>
> ---
> kernel/rcupreempt.c | 2 --
> 1 file changed, 2 deletions(-)
>
> Index: linux-tip.git/kernel/rcupreempt.c
> ===================================================================
> --- linux-tip.git.orig/kernel/rcupreempt.c 2008-05-22 11:12:30.000000000 -0700
> +++ linux-tip.git/kernel/rcupreempt.c 2008-05-22 11:12:33.000000000 -0700
> @@ -217,8 +217,6 @@ long rcu_batches_completed(void)
> }
> EXPORT_SYMBOL_GPL(rcu_batches_completed);
>
> -EXPORT_SYMBOL_GPL(rcu_batches_completed_bh);
> -
> void __rcu_read_lock(void)
> {
> int idx;
>
next prev parent reply other threads:[~2008-05-23 14:14 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-05-22 18:18 [PATCH] rcupreempt: remove export of rcu_batches_completed_bh Steven Rostedt
2008-05-22 18:18 ` Steven Rostedt
2008-05-23 14:14 ` Paul E. McKenney [this message]
2008-05-23 14:14 ` Paul E. McKenney
2008-05-27 15:36 ` Thomas Gleixner
2008-05-27 15:36 ` Thomas Gleixner
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20080523141403.GA8798@linux.vnet.ibm.com \
--to=paulmck@linux.vnet.ibm.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linuxppc-dev@ozlabs.org \
--cc=mingo@elte.hu \
--cc=paulus@samba.org \
--cc=rostedt@goodmis.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.