All of lore.kernel.org
 help / color / mirror / Atom feed
From: Rik van Riel <riel@redhat.com>
To: "Kristian Høgsberg" <krh@redhat.com>
Cc: linux-kernel@vger.kernel.org, "Kristian Høgsberg" <krh@redhat.com>
Subject: Re: [PATCH 1/2] Use structs instead of hardcoded offsets in x86 boot decompressor.
Date: Fri, 23 May 2008 21:07:44 -0400	[thread overview]
Message-ID: <20080523210744.52fe7fde@bree.surriel.com> (raw)
In-Reply-To: <1211579968-15227-1-git-send-email-krh@redhat.com>

On Fri, 23 May 2008 17:59:27 -0400
Kristian Høgsberg <krh@redhat.com> wrote:

> Signed-off-by: Kristian Høgsberg <krh@redhat.com>

Acked-by: Rik van Riel <riel@redhat.com>


> +static struct boot_params *real_mode;		/* Pointer to real-mode data */
> +static struct screen_info *rm_screen_info;	/* Pointer to real-mode data */

People who wonder why these pointers never get initialized: they
point to the zeropage, which of course lives at address zero.

/* The so-called "zeropage" */
struct boot_params {
	struct screen_info screen_info;                 /* 0x000 */
        struct apm_bios_info apm_bios_info;             /* 0x040 */
        __u8  _pad2[12];                                /* 0x054 */
        struct ist_info ist_info;                       /* 0x060 */
	...

-- 
All rights reversed.

  parent reply	other threads:[~2008-05-24  1:08 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-05-23 21:59 [PATCH 1/2] Use structs instead of hardcoded offsets in x86 boot decompressor Kristian Høgsberg
2008-05-23 21:59 ` [PATCH 2/2] Only print "Decompressing Linux" etc when 'noisy' is passed Kristian Høgsberg
2008-05-23 22:42   ` Johannes Weiner
2008-05-24  9:25   ` Mikael Pettersson
2008-05-24 18:07     ` Diego Calleja
2008-05-24  1:07 ` Rik van Riel [this message]
2008-05-24  6:17   ` [PATCH 1/2] Use structs instead of hardcoded offsets in x86 boot decompressor H. Peter Anvin
2008-05-25  4:03     ` Rik van Riel
2008-05-25  4:06       ` H. Peter Anvin
2008-05-25  4:25         ` Kristian Høgsberg

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20080523210744.52fe7fde@bree.surriel.com \
    --to=riel@redhat.com \
    --cc=krh@redhat.com \
    --cc=linux-kernel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.