Re: [patch 07/18] hugetlbfs: per mount hstates

[Nishanth Aravamudan <nacc@us.ibm.com>]

On 24.05.2008 [00:49:58 +0200], Nick Piggin wrote:
> On Fri, May 23, 2008 at 01:34:44PM -0700, Nishanth Aravamudan wrote:
> > On 23.05.2008 [07:24:25 +0200], Nick Piggin wrote:
> > > On Fri, Apr 25, 2008 at 11:09:33AM -0700, Nishanth Aravamudan wrote:
> > > True, but it is quite a long process and it is nice to have it working
> > > each step of the way in small steps... I think the overall way Andi's
> > > done the patchset is quite nice.
> > 
> > Yeah, I'm sorry if my review came across as overly critical at the time.
> > I really am impressed with the amount of change and how it was
> > presented. But, in all honesty, given that I have not seen many patches
> > from Andi nor yourself for hugetlbfs code in the past few years, nor do
> > I expect to see many in the future, I was trying to keep the code as
> > sensible as possible for those of us that do interact with it regularly
> > (and its userspace interface, especially !SHM_HUGETLB).
> 
> Yes it's important you're happy with it for that reason. So I have
> made a lot of changes you suggested, and other things if you feel
> strongly about could be changed.

Which I also greatly appreciate :) I think everything else is probably
in a good enough state to be in -mm now, and any clean-ups/add-ons can
happen there.

Thanks,
Nish

-- 
Nishanth Aravamudan <nacc@us.ibm.com>
IBM Linux Technology Center

--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org.  For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>