From: Andi Kleen <andi@firstfloor.org>
To: Miquel van Smoorenburg <miquels@cistron.nl>
Cc: Andi Kleen <andi@firstfloor.org>,
Glauber Costa <gcosta@redhat.com>,
linux-kernel@vger.kernel.org, linux-mm@kvack.org,
andi-suse@firstfloor.org
Subject: Re: 2.6.26: x86/kernel/pci_dma.c: gfp |= __GFP_NORETRY ?
Date: Sun, 25 May 2008 18:35:39 +0200 [thread overview]
Message-ID: <20080525163539.GA8405@one.firstfloor.org> (raw)
In-Reply-To: <1211657898.25661.2.camel@localhost.localdomain>
> So how about linux-2.6.26-gfp-no-oom.patch (see previous mail) for
> 2.6.26
Changing the gfp once globally like you did is not right, because
the different fallback cases have to be handled differently
(see the different cases I discussed in my earlier mail)
Especially the 16MB zone allocation should never trigger the OOM killer.
That could be special cased, but __GFP_NO_OOM_KILLER is likely better
as a short term fix although I'm still not 100% sure what implications
it will have to do more VM replies in the early fallbacks.
-Andi
WARNING: multiple messages have this Message-ID (diff)
From: Andi Kleen <andi@firstfloor.org>
To: Miquel van Smoorenburg <miquels@cistron.nl>
Cc: Andi Kleen <andi@firstfloor.org>,
Glauber Costa <gcosta@redhat.com>,
linux-kernel@vger.kernel.org, linux-mm@kvack.org,
andi-suse@firstfloor.org
Subject: Re: 2.6.26: x86/kernel/pci_dma.c: gfp |= __GFP_NORETRY ?
Date: Sun, 25 May 2008 18:35:39 +0200 [thread overview]
Message-ID: <20080525163539.GA8405@one.firstfloor.org> (raw)
In-Reply-To: <1211657898.25661.2.camel@localhost.localdomain>
> So how about linux-2.6.26-gfp-no-oom.patch (see previous mail) for
> 2.6.26
Changing the gfp once globally like you did is not right, because
the different fallback cases have to be handled differently
(see the different cases I discussed in my earlier mail)
Especially the 16MB zone allocation should never trigger the OOM killer.
That could be special cased, but __GFP_NO_OOM_KILLER is likely better
as a short term fix although I'm still not 100% sure what implications
it will have to do more VM replies in the early fallbacks.
-Andi
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
next prev parent reply other threads:[~2008-05-25 16:27 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-05-21 11:30 2.6.26: x86/kernel/pci_dma.c: gfp |= __GFP_NORETRY ? Miquel van Smoorenburg
2008-05-21 11:30 ` Miquel van Smoorenburg
2008-05-21 12:49 ` Glauber Costa
2008-05-21 12:49 ` Glauber Costa
2008-05-22 8:47 ` Andi Kleen
2008-05-22 8:47 ` Andi Kleen
2008-05-22 19:25 ` Miquel van Smoorenburg
2008-05-22 19:25 ` Miquel van Smoorenburg
2008-05-24 19:38 ` Miquel van Smoorenburg
2008-05-24 19:38 ` Miquel van Smoorenburg
2008-05-25 16:35 ` Andi Kleen [this message]
2008-05-25 16:35 ` Andi Kleen
2008-05-25 19:55 ` Alan Cox
2008-05-25 19:55 ` Alan Cox
2008-05-25 21:23 ` Andi Kleen
2008-05-25 21:23 ` Andi Kleen
2008-05-25 22:02 ` Alan Cox
2008-05-25 22:02 ` Alan Cox
2008-05-22 19:58 ` Thomas Gleixner
2008-05-22 19:58 ` Thomas Gleixner
2008-05-22 22:59 ` Andi Kleen
2008-05-22 22:59 ` Andi Kleen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20080525163539.GA8405@one.firstfloor.org \
--to=andi@firstfloor.org \
--cc=andi-suse@firstfloor.org \
--cc=gcosta@redhat.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=miquels@cistron.nl \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.