From: Jens Axboe <jens.axboe@oracle.com>
To: "Alan D. Brunelle" <Alan.Brunelle@hp.com>
Cc: "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
linux-btrace@vger.kernel.org
Subject: Re: [PATCH 1/2] Added in MESSAGE notes for blktraces
Date: Tue, 27 May 2008 13:32:06 +0000 [thread overview]
Message-ID: <20080527133206.GU7712@kernel.dk> (raw)
In-Reply-To: <483C0216.70008@hp.com>
On Tue, May 27 2008, Alan D. Brunelle wrote:
> +#define blk_add_trace_msg(q, fmt, ...) \
> + do { \
> + struct blk_trace *bt = (q)->blk_trace; \
> + if (unlikely(bt)) \
> + __trace_note_message(bt, fmt, ##__VA_ARGS__); \
> + } while (0)
> +#define BLK_TN_MAX_MSG 1024
BTW, I think we need to make this a lot smaller. Something like 128
chars should be enough, I think. 1K is just too much stack size to use
here.
--
Jens Axboe
WARNING: multiple messages have this Message-ID (diff)
From: Jens Axboe <jens.axboe@oracle.com>
To: "Alan D. Brunelle" <Alan.Brunelle@hp.com>
Cc: "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
linux-btrace@vger.kernel.org
Subject: Re: [PATCH 1/2] Added in MESSAGE notes for blktraces
Date: Tue, 27 May 2008 15:32:06 +0200 [thread overview]
Message-ID: <20080527133206.GU7712@kernel.dk> (raw)
In-Reply-To: <483C0216.70008@hp.com>
On Tue, May 27 2008, Alan D. Brunelle wrote:
> +#define blk_add_trace_msg(q, fmt, ...) \
> + do { \
> + struct blk_trace *bt = (q)->blk_trace; \
> + if (unlikely(bt)) \
> + __trace_note_message(bt, fmt, ##__VA_ARGS__); \
> + } while (0)
> +#define BLK_TN_MAX_MSG 1024
BTW, I think we need to make this a lot smaller. Something like 128
chars should be enough, I think. 1K is just too much stack size to use
here.
--
Jens Axboe
next prev parent reply other threads:[~2008-05-27 13:32 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-05-27 12:44 [PATCH 1/2] Added in MESSAGE notes for blktraces Alan D. Brunelle
2008-05-27 12:44 ` Alan D. Brunelle
2008-05-27 12:45 ` [PATCH 2/2] Added in elevator switch message to blktrace stream Alan D. Brunelle
2008-05-27 12:45 ` Alan D. Brunelle
2008-05-27 12:52 ` [PATCH 1/2] Added in MESSAGE notes for blktraces Jens Axboe
2008-05-27 12:52 ` Jens Axboe
2008-05-27 13:32 ` Jens Axboe [this message]
2008-05-27 13:32 ` Jens Axboe
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20080527133206.GU7712@kernel.dk \
--to=jens.axboe@oracle.com \
--cc=Alan.Brunelle@hp.com \
--cc=linux-btrace@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.