All of lore.kernel.org
 help / color / mirror / Atom feed
From: Alan Cox <alan@lxorguk.ukuu.org.uk>
To: Linus Torvalds <torvalds@linux-foundation.org>
Cc: Jeff Garzik <jeff@garzik.org>,
	linux-kernel@vger.kernel.org, linux-ide@vger.kernel.org
Subject: Re: RESEND: [PATCH] libata-sff: Fix oops reported in kerneloops.org for pnp devices with no ctl
Date: Thu, 29 May 2008 22:19:22 +0100	[thread overview]
Message-ID: <20080529221922.48c9fcb8@core> (raw)
In-Reply-To: <alpine.LFD.1.10.0805291403030.3873@woody.linux-foundation.org>

> 	void ata_sff_pause(struct ata_port *ap)
> 	{
> 		ata_sff_altstatus();
> 		ndelay(400);
> 	}
> 
> and again, if there is no altstatus register, that's a low-level driver 
> issue.

This takes away the ability to shoot yourself directly in the foot and
replaces it with the ability to shoot yourself in the foot in a more
abstract way. The dma_pause case still needs to check as that is the one
where you can make an actual mess but yes it certainly cleans up the
others.

(Next rev brewing ;))

  reply	other threads:[~2008-05-29 21:34 UTC|newest]

Thread overview: 22+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-05-29 16:25 RESEND: [PATCH] libata-sff: Fix oops reported in kerneloops.org for pnp devices with no ctl Alan Cox
2008-05-29 17:04 ` Linus Torvalds
2008-05-29 17:46   ` Jeff Garzik
2008-05-29 18:04     ` Linus Torvalds
2008-05-29 18:13       ` Jeff Garzik
2008-05-29 18:29       ` Alan Cox
2008-05-29 18:19     ` Alan Cox
2008-05-29 21:13       ` Linus Torvalds
2008-05-29 21:19         ` Alan Cox [this message]
2008-05-29 18:02   ` Alan Cox
2008-05-29 18:25     ` Jeff Garzik
2008-05-29 18:38       ` Alan Cox
2008-05-29 19:46         ` Linus Torvalds
2008-05-29 20:18           ` Alan Cox
2008-05-29 18:42       ` Alan Cox
2008-05-29 19:31         ` Jeff Garzik
2008-05-29 21:10           ` [RFC PATCH] " Alan Cox
2008-05-29 21:37             ` Alan Cox
2008-05-29 21:57               ` Jeff Garzik
2008-05-29 21:57                 ` Alan Cox
2008-05-30 22:14             ` Jeff Garzik
2008-06-04 10:45             ` Jeff Garzik

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20080529221922.48c9fcb8@core \
    --to=alan@lxorguk.ukuu.org.uk \
    --cc=jeff@garzik.org \
    --cc=linux-ide@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=torvalds@linux-foundation.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.