From: Jeff Garzik <jeff@garzik.org>
To: Linus Torvalds <torvalds@linux-foundation.org>
Cc: Alan Cox <alan@lxorguk.ukuu.org.uk>,
linux-kernel@vger.kernel.org, linux-ide@vger.kernel.org
Subject: Re: RESEND: [PATCH] libata-sff: Fix oops reported in kerneloops.org for pnp devices with no ctl
Date: Thu, 29 May 2008 14:13:51 -0400 [thread overview]
Message-ID: <483EF25F.7080005@garzik.org> (raw)
In-Reply-To: <alpine.LFD.1.10.0805291102370.2958@woody.linux-foundation.org>
Linus Torvalds wrote:
>
> On Thu, 29 May 2008, Jeff Garzik wrote:
>>> It may be that you meant to make it an "else if" case, ie if there was no
>>> IO-read, then you do a ndelay(400) as a last desperate case, but that's not
>>> how your ata_sdd_sync() is actually written.
>> The double-ndelay is definitely wrong, but we do need one. Technically it
>> should -only- be a 400ns delay, but we also have a register read in there to
>> make sure any posted writes are flushed.
>
> Well, but the "read + delay" is already in ata_sdd_pause().
Right, that's what I meant by double-ndelay.
> So it's "ata_sdd_sync()" that I think is bogus. Based on its name alone,
> it shouldn't have a delay in it (except, as mentioned, possibly for the
> fallback case where no port can be used for reading).
Agreed,
Jeff
next prev parent reply other threads:[~2008-05-29 18:14 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-05-29 16:25 RESEND: [PATCH] libata-sff: Fix oops reported in kerneloops.org for pnp devices with no ctl Alan Cox
2008-05-29 17:04 ` Linus Torvalds
2008-05-29 17:46 ` Jeff Garzik
2008-05-29 18:04 ` Linus Torvalds
2008-05-29 18:13 ` Jeff Garzik [this message]
2008-05-29 18:29 ` Alan Cox
2008-05-29 18:19 ` Alan Cox
2008-05-29 21:13 ` Linus Torvalds
2008-05-29 21:19 ` Alan Cox
2008-05-29 18:02 ` Alan Cox
2008-05-29 18:25 ` Jeff Garzik
2008-05-29 18:38 ` Alan Cox
2008-05-29 19:46 ` Linus Torvalds
2008-05-29 20:18 ` Alan Cox
2008-05-29 18:42 ` Alan Cox
2008-05-29 19:31 ` Jeff Garzik
2008-05-29 21:10 ` [RFC PATCH] " Alan Cox
2008-05-29 21:37 ` Alan Cox
2008-05-29 21:57 ` Jeff Garzik
2008-05-29 21:57 ` Alan Cox
2008-05-30 22:14 ` Jeff Garzik
2008-06-04 10:45 ` Jeff Garzik
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=483EF25F.7080005@garzik.org \
--to=jeff@garzik.org \
--cc=alan@lxorguk.ukuu.org.uk \
--cc=linux-ide@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=torvalds@linux-foundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.