All of lore.kernel.org
 help / color / mirror / Atom feed
From: Robert Millan <rmh@aybabtu.com>
To: grub-devel@gnu.org
Subject: backwards compatibility in grub.cfg
Date: Fri, 30 May 2008 23:20:32 +0200	[thread overview]
Message-ID: <20080530212032.GA1672@thorin> (raw)

[-- Attachment #1: Type: text/plain, Size: 666 bytes --]


Hi,

I'm adding this to the Debian package.  We need this for backwards
compatibility in case the new update-grub is used in combination with an
older install of GRUB in /boot/grub (which will surely happen a lot).

I'm wondering if it makes sense to commit this in official GRUB too.  For
people installing by hand it's not a problem, and distributors can sort it
out themselves, I guess, but it may also be helpful.  What do you think?

(we have similar checks like "if font " in 00_header, but this is much
uglier)

-- 
Robert Millan

<GPLv2> I know my rights; I want my phone call!
<DRM> What good is a phone call… if you are unable to speak?
(as seen on /.)

[-- Attachment #2: compat.diff --]
[-- Type: text/x-diff, Size: 780 bytes --]

diff -x configure -x config.h.in -x CVS -x '*~' -x '*.mk' -urp ../grub2/util/update-grub_lib.in ./util/update-grub_lib.in
--- ../grub2/util/update-grub_lib.in	2008-05-30 22:55:35.000000000 +0200
+++ ./util/update-grub_lib.in	2008-05-30 23:16:53.000000000 +0200
@@ -116,10 +116,9 @@ prepare_grub_to_access_device ()
 
   # If there's a filesystem UUID that GRUB is capable of identifiing, use it;
   # otherwise set root as per value in device.map.
+  echo "set root=`${grub_probe} --device ${device} --target=drive`"
   if fs_uuid="`grub-probe --device ${device} --target=fs_uuid 2> /dev/null`" ; then
     echo "search --fs-uuid --set ${fs_uuid}"
-  else
-    echo "set root=`${grub_probe} --device ${device} --target=drive`"
   fi
 
   # Abstraction modules aren't auto-loaded.

             reply	other threads:[~2008-05-30 21:20 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-05-30 21:20 Robert Millan [this message]
2008-05-30 21:47 ` backwards compatibility in grub.cfg Christian Franke
2008-05-31  9:47   ` Robert Millan
2008-05-30 22:23 ` Pavel Roskin
2008-05-31  9:38   ` Robert Millan
2008-06-01  6:21     ` Pavel Roskin
2008-06-01 10:43       ` Robert Millan

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20080530212032.GA1672@thorin \
    --to=rmh@aybabtu.com \
    --cc=grub-devel@gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.