From: Christian Franke <Christian.Franke@t-online.de>
To: The development of GRUB 2 <grub-devel@gnu.org>
Subject: Re: backwards compatibility in grub.cfg
Date: Fri, 30 May 2008 23:47:18 +0200 [thread overview]
Message-ID: <484075E6.9030709@t-online.de> (raw)
In-Reply-To: <20080530212032.GA1672@thorin>
Robert Millan wrote:
> diff -x configure -x config.h.in -x CVS -x '*~' -x '*.mk' -urp ../grub2/util/update-grub_lib.in ./util/update-grub_lib.in
> --- ../grub2/util/update-grub_lib.in 2008-05-30 22:55:35.000000000 +0200
> +++ ./util/update-grub_lib.in 2008-05-30 23:16:53.000000000 +0200
> @@ -116,10 +116,9 @@ prepare_grub_to_access_device ()
>
> # If there's a filesystem UUID that GRUB is capable of identifiing, use it;
> # otherwise set root as per value in device.map.
> + echo "set root=`${grub_probe} --device ${device} --target=drive`"
> if fs_uuid="`grub-probe --device ${device} --target=fs_uuid 2> /dev/null`" ; then
>
Outside of the scope of the patch, but shouldn't '${grub_probe}' be used
instead of 'grub-probe' in the rest of the script?
Same issue is in update-grub.in: grub_probe is set but never used, so
update-grub fails if /usr/sbin is not in PATH.
--
Christian Franke
next prev parent reply other threads:[~2008-05-30 21:47 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-05-30 21:20 backwards compatibility in grub.cfg Robert Millan
2008-05-30 21:47 ` Christian Franke [this message]
2008-05-31 9:47 ` Robert Millan
2008-05-30 22:23 ` Pavel Roskin
2008-05-31 9:38 ` Robert Millan
2008-06-01 6:21 ` Pavel Roskin
2008-06-01 10:43 ` Robert Millan
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=484075E6.9030709@t-online.de \
--to=christian.franke@t-online.de \
--cc=grub-devel@gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.