All of lore.kernel.org
 help / color / mirror / Atom feed
* [PATCH] ide-generic: add missing hwif->chipset setup
@ 2008-05-31 13:43 Bartlomiej Zolnierkiewicz
  0 siblings, 0 replies; only message in thread
From: Bartlomiej Zolnierkiewicz @ 2008-05-31 13:43 UTC (permalink / raw)
  To: linux-kernel; +Cc: linux-ide, John Keller, Dmitri Vorobiev, Mel Gorman

hwif->chipset need to be set properly or ide-generic driver will break once
we make a final step in fixing host drivers' dependence on ide_hwifs[].

Problem was catched early thanks to IDE tree exposure in -mm / -next trees
and reported by people listed people (thank you guys!).

Reported-by: "John Keller" <jpk@sgi.com>
Reported-by: Dmitri Vorobiev <dmitri.vorobiev@gmail.com>
Reported-by: Mel Gorman <mel@csn.ul.ie>
Signed-off-by: Bartlomiej Zolnierkiewicz <bzolnier@gmail.com>
---
With this patch applied we can bring "ide: fix hwif-s initialization"
and "ide: make ide_hwifs[] static" patches back into IDE tree! :)

 drivers/ide/ide-generic.c |    1 +
 1 file changed, 1 insertion(+)

Index: b/drivers/ide/ide-generic.c
===================================================================
--- a/drivers/ide/ide-generic.c
+++ b/drivers/ide/ide-generic.c
@@ -125,6 +125,7 @@ static int __init ide_generic_init(void)
 			memset(&hw, 0, sizeof(hw));
 			ide_std_init_ports(&hw, io_addr, io_addr + 0x206);
 			hw.irq = ide_default_irq(io_addr);
+			hw.chipset = ide_generic;
 			ide_init_port_hw(hwif, &hw);
 
 			idx[i] = i;

^ permalink raw reply	[flat|nested] only message in thread

only message in thread, other threads:[~2008-05-31 13:49 UTC | newest]

Thread overview: (only message) (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2008-05-31 13:43 [PATCH] ide-generic: add missing hwif->chipset setup Bartlomiej Zolnierkiewicz

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.