From: Paul Mundt <lethal@linux-sh.org>
To: Pekka J Enberg <penberg@cs.helsinki.fi>
Cc: David Howells <dhowells@redhat.com>,
Christoph Lameter <clameter@sgi.com>,
LKML <linux-kernel@vger.kernel.org>,
cooloney@kernel.org, akpm@linux-foundation.org, mpm@selenic.com
Subject: Re: [PATCH] nommu: fix kobjsize() for SLOB and SLUB
Date: Sun, 1 Jun 2008 19:24:01 +0900 [thread overview]
Message-ID: <20080601102401.GD25429@linux-sh.org> (raw)
In-Reply-To: <Pine.LNX.4.64.0806011208480.13090@sbz-30.cs.Helsinki.FI>
On Sun, Jun 01, 2008 at 12:13:02PM +0300, Pekka J Enberg wrote:
> Hi Paul,
>
> On Sun, 1 Jun 2008, Paul Mundt wrote:
> > This still needs to be virt_to_head_page() I think.
> >
> > I don't have my nommu boards at home, so I'll test at the office tomorow
> > morning and let you know.
>
> I was about to send a patch that fixes some of the kobjsize() abuses to
> use ksize() but then I realized that what we probably should do is
> something like this instead.
>
> I mean, assuming the BUG_ON bits are bogus, then we should always pass the
> pointer to the allocator. I audited most of the callers and they all seem
> to be really just using kmalloc() for allocation anyway.
>
> What do you think?
>
Isn't this what my original patch did? ;-)
next prev parent reply other threads:[~2008-06-01 10:26 UTC|newest]
Thread overview: 43+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <Pine.LNX.4.64.0805281646470.27125@sbz-30.cs.Helsinki.FI>
[not found] ` <20080528153648.GA27783@linux-sh.org>
2008-05-28 20:03 ` [PATCH] nommu: fix kobjsize() for SLOB and SLUB Pekka Enberg
2008-05-28 20:25 ` Christoph Lameter
2008-05-28 20:25 ` Pekka Enberg
2008-05-28 20:29 ` Christoph Lameter
2008-05-29 13:08 ` David Howells
2008-05-29 13:21 ` Pekka J Enberg
2008-05-29 21:12 ` Paul Mundt
2008-06-01 7:58 ` Pekka Enberg
2008-06-01 8:22 ` Pekka J Enberg
2008-06-01 8:24 ` Paul Mundt
2008-06-01 8:36 ` Pekka J Enberg
2008-06-01 9:13 ` Pekka J Enberg
2008-06-01 10:24 ` Paul Mundt [this message]
2008-06-01 10:29 ` Pekka Enberg
2008-06-01 11:21 ` Paul Mundt
2008-06-01 11:30 ` Pekka J Enberg
2008-06-02 5:59 ` Paul Mundt
2008-06-02 6:32 ` Pekka Enberg
2008-06-02 6:50 ` Paul Mundt
2008-06-02 6:58 ` Pekka Enberg
2008-06-02 7:01 ` Paul Mundt
2008-06-01 8:22 ` Paul Mundt
2008-05-29 15:00 ` Christoph Lameter
2008-05-22 16:09 Pekka J Enberg
2008-05-22 16:48 ` Christoph Lameter
2008-05-22 23:40 ` Paul Mundt
2008-05-22 23:45 ` Christoph Lameter
2008-05-22 23:50 ` Paul Mundt
2008-05-23 0:04 ` Christoph Lameter
2008-05-28 13:12 ` David Howells
2008-05-28 13:17 ` Pekka J Enberg
2008-05-28 13:40 ` David Howells
2008-05-28 14:09 ` David Howells
2008-05-28 17:26 ` Christoph Lameter
2008-05-28 17:38 ` David Howells
2008-05-28 20:35 ` Mike Frysinger
2008-05-29 13:03 ` David Howells
2008-05-29 20:25 ` Mike Frysinger
2008-05-29 20:30 ` Christoph Lameter
2008-05-29 20:51 ` Mike Frysinger
2008-05-29 21:29 ` Christoph Lameter
2008-05-30 4:18 ` Mike Frysinger
2008-05-28 14:27 ` David Howells
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20080601102401.GD25429@linux-sh.org \
--to=lethal@linux-sh.org \
--cc=akpm@linux-foundation.org \
--cc=clameter@sgi.com \
--cc=cooloney@kernel.org \
--cc=dhowells@redhat.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mpm@selenic.com \
--cc=penberg@cs.helsinki.fi \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.