From: David Howells <dhowells@redhat.com>
To: Pekka J Enberg <penberg@cs.helsinki.fi>
Cc: dhowells@redhat.com, clameter@sgi.com, mpm@selenic.com,
lethal@linux-sh.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] nommu: fix kobjsize() for SLOB and SLUB
Date: Wed, 28 May 2008 14:12:35 +0100 [thread overview]
Message-ID: <2874.1211980355@redhat.com> (raw)
In-Reply-To: <Pine.LNX.4.64.0805221907250.4056@sbz-30.cs.Helsinki.FI>
Pekka J Enberg <penberg@cs.helsinki.fi> wrote:
> From: Christoph Lameter <clameter@sgi.com>
>
> As reported by Paul Mundt, kobjsize() does not work properly with SLOB and SLUB
> that re-use parts of struct page for their own purposes. Fix it up by using
> compound_order() for compound pages that don't have PageSlab set.
>
> Reported-by: Paul Mundt <lethal@linux-sh.org>
> Cc: Christoph Lameter <clameter@sgi.com>
> Signed-off-by: Pekka Enberg <penberg@cs.helsinki.fi>
> ---
> I kept the original object size calculation for non-compound pages in this
> version. It looks like the nommu code uses kobjsize() for all sorts of
> interesting things.
Works for SLAB and SLUB. SLOB breaks well before getting to anything these
patches affect.
Acked-by: David Howells <dhowells@redhat.com>
next prev parent reply other threads:[~2008-05-28 13:13 UTC|newest]
Thread overview: 43+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-05-22 16:09 [PATCH] nommu: fix kobjsize() for SLOB and SLUB Pekka J Enberg
2008-05-22 16:48 ` Christoph Lameter
2008-05-22 23:40 ` Paul Mundt
2008-05-22 23:45 ` Christoph Lameter
2008-05-22 23:50 ` Paul Mundt
2008-05-23 0:04 ` Christoph Lameter
2008-05-28 13:12 ` David Howells [this message]
2008-05-28 13:17 ` Pekka J Enberg
2008-05-28 13:40 ` David Howells
2008-05-28 14:09 ` David Howells
2008-05-28 17:26 ` Christoph Lameter
2008-05-28 17:38 ` David Howells
2008-05-28 20:35 ` Mike Frysinger
2008-05-29 13:03 ` David Howells
2008-05-29 20:25 ` Mike Frysinger
2008-05-29 20:30 ` Christoph Lameter
2008-05-29 20:51 ` Mike Frysinger
2008-05-29 21:29 ` Christoph Lameter
2008-05-30 4:18 ` Mike Frysinger
2008-05-28 14:27 ` David Howells
[not found] <Pine.LNX.4.64.0805281646470.27125@sbz-30.cs.Helsinki.FI>
[not found] ` <20080528153648.GA27783@linux-sh.org>
2008-05-28 20:03 ` Pekka Enberg
2008-05-28 20:25 ` Christoph Lameter
2008-05-28 20:25 ` Pekka Enberg
2008-05-28 20:29 ` Christoph Lameter
2008-05-29 13:08 ` David Howells
2008-05-29 13:21 ` Pekka J Enberg
2008-05-29 21:12 ` Paul Mundt
2008-06-01 7:58 ` Pekka Enberg
2008-06-01 8:22 ` Pekka J Enberg
2008-06-01 8:24 ` Paul Mundt
2008-06-01 8:36 ` Pekka J Enberg
2008-06-01 9:13 ` Pekka J Enberg
2008-06-01 10:24 ` Paul Mundt
2008-06-01 10:29 ` Pekka Enberg
2008-06-01 11:21 ` Paul Mundt
2008-06-01 11:30 ` Pekka J Enberg
2008-06-02 5:59 ` Paul Mundt
2008-06-02 6:32 ` Pekka Enberg
2008-06-02 6:50 ` Paul Mundt
2008-06-02 6:58 ` Pekka Enberg
2008-06-02 7:01 ` Paul Mundt
2008-06-01 8:22 ` Paul Mundt
2008-05-29 15:00 ` Christoph Lameter
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2874.1211980355@redhat.com \
--to=dhowells@redhat.com \
--cc=clameter@sgi.com \
--cc=lethal@linux-sh.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mpm@selenic.com \
--cc=penberg@cs.helsinki.fi \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.