From: akinobu.mita@gmail.com
To: linux-kernel@vger.kernel.org
Cc: Geert Uytterhoeven <geert@linux-m68k.org>
Subject: [patch -v2 19/23] zorro: use memory_read_from_buffer
Date: Mon, 02 Jun 2008 08:13:48 +0900 [thread overview]
Message-ID: <20080601231633.611599860@gmail.com> (raw)
In-Reply-To: 20080601231329.223608711@gmail.com
[-- Attachment #1: zorro-use-memory-read-from-buffer.patch --]
[-- Type: text/plain, Size: 1226 bytes --]
Signed-off-by: Akinobu Mita <akinobu.mita@gmail.com>
Cc: Geert Uytterhoeven <geert@linux-m68k.org>
---
drivers/zorro/zorro-sysfs.c | 10 ++--------
1 file changed, 2 insertions(+), 8 deletions(-)
Index: 2.6-git/drivers/zorro/zorro-sysfs.c
===================================================================
--- 2.6-git.orig/drivers/zorro/zorro-sysfs.c
+++ 2.6-git/drivers/zorro/zorro-sysfs.c
@@ -15,6 +15,7 @@
#include <linux/zorro.h>
#include <linux/stat.h>
#include <linux/string.h>
+#include <linux/fs.h>
#include "zorro.h"
@@ -56,12 +57,6 @@ static ssize_t zorro_read_config(struct
struct zorro_dev *z = to_zorro_dev(container_of(kobj, struct device,
kobj));
struct ConfigDev cd;
- unsigned int size = sizeof(cd);
-
- if (off > size)
- return 0;
- if (off+count > size)
- count = size-off;
/* Construct a ConfigDev */
memset(&cd, 0, sizeof(cd));
@@ -71,8 +66,7 @@ static ssize_t zorro_read_config(struct
cd.cd_BoardAddr = (void *)zorro_resource_start(z);
cd.cd_BoardSize = zorro_resource_len(z);
- memcpy(buf, (void *)&cd+off, count);
- return count;
+ return memory_read_from_buffer(buf, count, &off, &cd, sizeof(cd));
}
static struct bin_attribute zorro_config_attr = {
--
next prev parent reply other threads:[~2008-06-01 23:33 UTC|newest]
Thread overview: 35+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-06-01 23:13 [patch -v2 00/23] use simple_read_from_buffer and memory_read_from_buffer akinobu.mita
2008-06-01 23:13 ` [patch -v2 01/23] sunrpc: use simple_read_from_buffer akinobu.mita
2008-06-02 5:35 ` Alexey Dobriyan
2008-06-02 12:11 ` Akinobu Mita
2008-06-01 23:13 ` [patch -v2 02/23] binfmt_misc: " akinobu.mita
2008-06-01 23:13 ` [patch -v2 03/23] ocfs2: " akinobu.mita
2008-06-01 23:27 ` [Ocfs2-devel] " akinobu.mita at gmail.com
2008-06-02 20:42 ` Joel Becker
2008-06-02 20:42 ` Joel Becker
2008-06-01 23:13 ` [patch -v2 04/23] ipc: " akinobu.mita
2008-06-01 23:13 ` [patch -v2 05/23] isdn: " akinobu.mita
2008-06-01 23:13 ` [patch -v2 06/23] s390/vmcp: " akinobu.mita
2008-06-02 8:53 ` Christian Borntraeger
2008-06-02 12:28 ` Akinobu Mita
2008-06-01 23:13 ` [patch -v2 07/23] s390: " akinobu.mita
2008-06-01 23:13 ` [patch -v2 08/23] nwflash: " akinobu.mita
2008-06-01 23:13 ` [patch -v2 09/23] usbmon: " akinobu.mita
2008-06-01 23:13 ` [patch -v2 10/23] ttusb: use simple_read_from_buffer() akinobu.mita
2008-06-01 23:13 ` [patch -v2 11/23] airo: use simple_read_from_buffer akinobu.mita
2008-06-01 23:13 ` akinobu.mita-Re5JQEeQqe8AvxtiuMwx3w
2008-06-01 23:13 ` akinobu.mita
2008-06-01 23:13 ` [patch -v2 12/23] cris: " akinobu.mita
2008-06-01 23:13 ` [patch -v2 13/23] introduce memory_read_from_buffer akinobu.mita
2008-06-01 23:13 ` [patch -v2 14/23] dcdbas: use memory_read_from_buffer akinobu.mita
2008-06-01 23:13 ` [patch -v2 15/23] dell_rbu: " akinobu.mita
2008-06-01 23:13 ` [patch -v2 16/23] firmware: " akinobu.mita
2008-06-01 23:13 ` [patch -v2 17/23] acpi: " akinobu.mita
2008-06-01 23:13 ` [patch -v2 18/23] aty: " akinobu.mita
2008-06-01 23:13 ` akinobu.mita
2008-06-01 23:13 ` akinobu.mita [this message]
2008-06-02 7:22 ` [patch -v2 19/23] zorro: " Geert Uytterhoeven
2008-06-01 23:13 ` [patch -v2 20/23] s390/cio: " akinobu.mita
2008-06-01 23:13 ` [patch -v2 21/23] s390: " akinobu.mita
2008-06-01 23:13 ` [patch -v2 22/23] ipr: " akinobu.mita
2008-06-01 23:13 ` [patch -v2 23/23] qla2xxx: " akinobu.mita
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20080601231633.611599860@gmail.com \
--to=akinobu.mita@gmail.com \
--cc=geert@linux-m68k.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.