All of lore.kernel.org
 help / color / mirror / Atom feed
From: akinobu.mita@gmail.com
To: linux-kernel@vger.kernel.org
Cc: "John W. Linville" <linville@tuxdriver.com>,
	netdev@vger.kernel.org, linux-wireless@vger.kernel.org
Subject: [patch -v2 11/23] airo: use simple_read_from_buffer
Date: Mon, 02 Jun 2008 08:13:40 +0900	[thread overview]
Message-ID: <20080601231543.372911291@gmail.com> (raw)
In-Reply-To: 20080601231329.223608711@gmail.com

Signed-off-by: Akinobu Mita <akinobu.mita@gmail.com>
Cc: John W. Linville <linville@tuxdriver.com>
Cc: netdev@vger.kernel.org
Cc: linux-wireless@vger.kernel.org
---
 drivers/net/wireless/airo.c |   15 +++------------
 1 file changed, 3 insertions(+), 12 deletions(-)

Index: 2.6-git/drivers/net/wireless/airo.c
===================================================================
--- 2.6-git.orig/drivers/net/wireless/airo.c
+++ 2.6-git/drivers/net/wireless/airo.c
@@ -4560,22 +4560,13 @@ static ssize_t proc_read( struct file *f
 			  size_t len,
 			  loff_t *offset )
 {
-	loff_t pos = *offset;
-	struct proc_data *priv = (struct proc_data*)file->private_data;
+	struct proc_data *priv = file->private_data;
 
 	if (!priv->rbuffer)
 		return -EINVAL;
 
-	if (pos < 0)
-		return -EINVAL;
-	if (pos >= priv->readlen)
-		return 0;
-	if (len > priv->readlen - pos)
-		len = priv->readlen - pos;
-	if (copy_to_user(buffer, priv->rbuffer + pos, len))
-		return -EFAULT;
-	*offset = pos + len;
-	return len;
+	return simple_read_from_buffer(buffer, len, offset, priv->rbuffer,
+					priv->readlen);
 }
 
 /*

-- 

WARNING: multiple messages have this Message-ID (diff)
From: akinobu.mita@gmail.com
To: linux-kernel@vger.kernel.org
Cc: "John W. Linville" <linville@tuxdriver.com>,
	netdev@vger.kernel.org, linux-wireless@vger.kernel.org
Subject: [patch -v2 11/23] airo: use simple_read_from_buffer
Date: Mon, 02 Jun 2008 08:13:40 +0900	[thread overview]
Message-ID: <20080601231543.372911291@gmail.com> (raw)
In-Reply-To: 20080601231329.223608711@gmail.com

[-- Attachment #1: airo-use-simple-read-from-buffer.patch --]
[-- Type: text/plain, Size: 1108 bytes --]

Signed-off-by: Akinobu Mita <akinobu.mita@gmail.com>
Cc: John W. Linville <linville@tuxdriver.com>
Cc: netdev@vger.kernel.org
Cc: linux-wireless@vger.kernel.org
---
 drivers/net/wireless/airo.c |   15 +++------------
 1 file changed, 3 insertions(+), 12 deletions(-)

Index: 2.6-git/drivers/net/wireless/airo.c
===================================================================
--- 2.6-git.orig/drivers/net/wireless/airo.c
+++ 2.6-git/drivers/net/wireless/airo.c
@@ -4560,22 +4560,13 @@ static ssize_t proc_read( struct file *f
 			  size_t len,
 			  loff_t *offset )
 {
-	loff_t pos = *offset;
-	struct proc_data *priv = (struct proc_data*)file->private_data;
+	struct proc_data *priv = file->private_data;
 
 	if (!priv->rbuffer)
 		return -EINVAL;
 
-	if (pos < 0)
-		return -EINVAL;
-	if (pos >= priv->readlen)
-		return 0;
-	if (len > priv->readlen - pos)
-		len = priv->readlen - pos;
-	if (copy_to_user(buffer, priv->rbuffer + pos, len))
-		return -EFAULT;
-	*offset = pos + len;
-	return len;
+	return simple_read_from_buffer(buffer, len, offset, priv->rbuffer,
+					priv->readlen);
 }
 
 /*

-- 

WARNING: multiple messages have this Message-ID (diff)
From: akinobu.mita-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org
To: linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
Cc: "John W. Linville"
	<linville-2XuSBdqkA4R54TAoqtyWWQ@public.gmane.org>,
	netdev-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
	linux-wireless-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
Subject: [patch -v2 11/23] airo: use simple_read_from_buffer
Date: Mon, 02 Jun 2008 08:13:40 +0900	[thread overview]
Message-ID: <20080601231543.372911291@gmail.com> (raw)
In-Reply-To: 20080601231329.223608711@gmail.com

[-- Attachment #1: airo-use-simple-read-from-buffer.patch --]
[-- Type: text/plain, Size: 1434 bytes --]

Signed-off-by: Akinobu Mita <akinobu.mita-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
Cc: John W. Linville <linville-2XuSBdqkA4R54TAoqtyWWQ@public.gmane.org>
Cc: netdev-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
Cc: linux-wireless-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
---
 drivers/net/wireless/airo.c |   15 +++------------
 1 file changed, 3 insertions(+), 12 deletions(-)

Index: 2.6-git/drivers/net/wireless/airo.c
===================================================================
--- 2.6-git.orig/drivers/net/wireless/airo.c
+++ 2.6-git/drivers/net/wireless/airo.c
@@ -4560,22 +4560,13 @@ static ssize_t proc_read( struct file *f
 			  size_t len,
 			  loff_t *offset )
 {
-	loff_t pos = *offset;
-	struct proc_data *priv = (struct proc_data*)file->private_data;
+	struct proc_data *priv = file->private_data;
 
 	if (!priv->rbuffer)
 		return -EINVAL;
 
-	if (pos < 0)
-		return -EINVAL;
-	if (pos >= priv->readlen)
-		return 0;
-	if (len > priv->readlen - pos)
-		len = priv->readlen - pos;
-	if (copy_to_user(buffer, priv->rbuffer + pos, len))
-		return -EFAULT;
-	*offset = pos + len;
-	return len;
+	return simple_read_from_buffer(buffer, len, offset, priv->rbuffer,
+					priv->readlen);
 }
 
 /*

-- 
--
To unsubscribe from this list: send the line "unsubscribe linux-wireless" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

  parent reply	other threads:[~2008-06-01 23:27 UTC|newest]

Thread overview: 35+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-06-01 23:13 [patch -v2 00/23] use simple_read_from_buffer and memory_read_from_buffer akinobu.mita
2008-06-01 23:13 ` [patch -v2 01/23] sunrpc: use simple_read_from_buffer akinobu.mita
2008-06-02  5:35   ` Alexey Dobriyan
2008-06-02 12:11     ` Akinobu Mita
2008-06-01 23:13 ` [patch -v2 02/23] binfmt_misc: " akinobu.mita
2008-06-01 23:13 ` [patch -v2 03/23] ocfs2: " akinobu.mita
2008-06-01 23:27   ` [Ocfs2-devel] " akinobu.mita at gmail.com
2008-06-02 20:42   ` Joel Becker
2008-06-02 20:42     ` Joel Becker
2008-06-01 23:13 ` [patch -v2 04/23] ipc: " akinobu.mita
2008-06-01 23:13 ` [patch -v2 05/23] isdn: " akinobu.mita
2008-06-01 23:13 ` [patch -v2 06/23] s390/vmcp: " akinobu.mita
2008-06-02  8:53   ` Christian Borntraeger
2008-06-02 12:28     ` Akinobu Mita
2008-06-01 23:13 ` [patch -v2 07/23] s390: " akinobu.mita
2008-06-01 23:13 ` [patch -v2 08/23] nwflash: " akinobu.mita
2008-06-01 23:13 ` [patch -v2 09/23] usbmon: " akinobu.mita
2008-06-01 23:13 ` [patch -v2 10/23] ttusb: use simple_read_from_buffer() akinobu.mita
2008-06-01 23:13 ` akinobu.mita [this message]
2008-06-01 23:13   ` [patch -v2 11/23] airo: use simple_read_from_buffer akinobu.mita-Re5JQEeQqe8AvxtiuMwx3w
2008-06-01 23:13   ` akinobu.mita
2008-06-01 23:13 ` [patch -v2 12/23] cris: " akinobu.mita
2008-06-01 23:13 ` [patch -v2 13/23] introduce memory_read_from_buffer akinobu.mita
2008-06-01 23:13 ` [patch -v2 14/23] dcdbas: use memory_read_from_buffer akinobu.mita
2008-06-01 23:13 ` [patch -v2 15/23] dell_rbu: " akinobu.mita
2008-06-01 23:13 ` [patch -v2 16/23] firmware: " akinobu.mita
2008-06-01 23:13 ` [patch -v2 17/23] acpi: " akinobu.mita
2008-06-01 23:13 ` [patch -v2 18/23] aty: " akinobu.mita
2008-06-01 23:13   ` akinobu.mita
2008-06-01 23:13 ` [patch -v2 19/23] zorro: " akinobu.mita
2008-06-02  7:22   ` Geert Uytterhoeven
2008-06-01 23:13 ` [patch -v2 20/23] s390/cio: " akinobu.mita
2008-06-01 23:13 ` [patch -v2 21/23] s390: " akinobu.mita
2008-06-01 23:13 ` [patch -v2 22/23] ipr: " akinobu.mita
2008-06-01 23:13 ` [patch -v2 23/23] qla2xxx: " akinobu.mita

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20080601231543.372911291@gmail.com \
    --to=akinobu.mita@gmail.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-wireless@vger.kernel.org \
    --cc=linville@tuxdriver.com \
    --cc=netdev@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.