From: Andrew Morton <akpm@linux-foundation.org>
To: npiggin@suse.de
Cc: shaggy@austin.ibm.com, linux-mm@kvack.org,
linux-arch@vger.kernel.org, apw@shadowen.org
Subject: Re: [patch 1/5] x86: implement pte_special
Date: Mon, 2 Jun 2008 16:58:47 -0700 [thread overview]
Message-ID: <20080602165847.dd19ddb1.akpm@linux-foundation.org> (raw)
In-Reply-To: <20080529122602.062780000@nick.local0.net>
On Thu, 29 May 2008 22:20:51 +1000
npiggin@suse.de wrote:
> Implement the pte_special bit for x86. This is required to support lockless
> get_user_pages, because we need to know whether or not we can refcount a
> particular page given only its pte (and no vma).
Spits this reject:
***************
*** 39,44 ****
#define _PAGE_UNUSED3 (_AC(1, L)<<_PAGE_BIT_UNUSED3)
#define _PAGE_PAT (_AC(1, L)<<_PAGE_BIT_PAT)
#define _PAGE_PAT_LARGE (_AC(1, L)<<_PAGE_BIT_PAT_LARGE)
#if defined(CONFIG_X86_64) || defined(CONFIG_X86_PAE)
#define _PAGE_NX (_AC(1, ULL) << _PAGE_BIT_NX)
--- 40,47 ----
#define _PAGE_UNUSED3 (_AC(1, L)<<_PAGE_BIT_UNUSED3)
#define _PAGE_PAT (_AC(1, L)<<_PAGE_BIT_PAT)
#define _PAGE_PAT_LARGE (_AC(1, L)<<_PAGE_BIT_PAT_LARGE)
+ #define _PAGE_SPECIAL (_AC(1, L)<<_PAGE_BIT_SPECIAL)
+ #define __HAVE_ARCH_PTE_SPECIAL
#if defined(CONFIG_X86_64) || defined(CONFIG_X86_PAE)
#define _PAGE_NX (_AC(1, ULL) << _PAGE_BIT_NX)
Which I fixed thusly:
#define _PAGE_PAT (_AT(pteval_t, 1) << _PAGE_BIT_PAT)
#define _PAGE_PAT_LARGE (_AT(pteval_t, 1) << _PAGE_BIT_PAT_LARGE)
#define _PAGE_SPECIAL (_AT(pteval_t, 1) << _PAGE_BIT_SPECIAL)
#define __HAVE_ARCH_PTE_SPECIAL
OK?
(Also please check the bunch of checkpatch fixes, a warning fix and a
compile fix).
WARNING: multiple messages have this Message-ID (diff)
From: Andrew Morton <akpm@linux-foundation.org>
To: npiggin@suse.de
Cc: shaggy@austin.ibm.com, linux-mm@kvack.org,
linux-arch@vger.kernel.org, apw@shadowen.org
Subject: Re: [patch 1/5] x86: implement pte_special
Date: Mon, 2 Jun 2008 16:58:47 -0700 [thread overview]
Message-ID: <20080602165847.dd19ddb1.akpm@linux-foundation.org> (raw)
In-Reply-To: <20080529122602.062780000@nick.local0.net>
On Thu, 29 May 2008 22:20:51 +1000
npiggin@suse.de wrote:
> Implement the pte_special bit for x86. This is required to support lockless
> get_user_pages, because we need to know whether or not we can refcount a
> particular page given only its pte (and no vma).
Spits this reject:
***************
*** 39,44 ****
#define _PAGE_UNUSED3 (_AC(1, L)<<_PAGE_BIT_UNUSED3)
#define _PAGE_PAT (_AC(1, L)<<_PAGE_BIT_PAT)
#define _PAGE_PAT_LARGE (_AC(1, L)<<_PAGE_BIT_PAT_LARGE)
#if defined(CONFIG_X86_64) || defined(CONFIG_X86_PAE)
#define _PAGE_NX (_AC(1, ULL) << _PAGE_BIT_NX)
--- 40,47 ----
#define _PAGE_UNUSED3 (_AC(1, L)<<_PAGE_BIT_UNUSED3)
#define _PAGE_PAT (_AC(1, L)<<_PAGE_BIT_PAT)
#define _PAGE_PAT_LARGE (_AC(1, L)<<_PAGE_BIT_PAT_LARGE)
+ #define _PAGE_SPECIAL (_AC(1, L)<<_PAGE_BIT_SPECIAL)
+ #define __HAVE_ARCH_PTE_SPECIAL
#if defined(CONFIG_X86_64) || defined(CONFIG_X86_PAE)
#define _PAGE_NX (_AC(1, ULL) << _PAGE_BIT_NX)
Which I fixed thusly:
#define _PAGE_PAT (_AT(pteval_t, 1) << _PAGE_BIT_PAT)
#define _PAGE_PAT_LARGE (_AT(pteval_t, 1) << _PAGE_BIT_PAT_LARGE)
#define _PAGE_SPECIAL (_AT(pteval_t, 1) << _PAGE_BIT_SPECIAL)
#define __HAVE_ARCH_PTE_SPECIAL
OK?
(Also please check the bunch of checkpatch fixes, a warning fix and a
compile fix).
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
next prev parent reply other threads:[~2008-06-02 23:59 UTC|newest]
Thread overview: 32+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20080529122050.823438000@nick.local0.net>
2008-05-29 12:20 ` [patch 1/5] x86: implement pte_special npiggin
2008-05-29 12:20 ` npiggin
2008-06-02 23:58 ` Andrew Morton [this message]
2008-06-02 23:58 ` Andrew Morton
2008-06-03 2:04 ` Nick Piggin
2008-06-03 2:04 ` Nick Piggin
2008-06-04 17:14 ` Andy Whitcroft
2008-06-04 17:14 ` Andy Whitcroft
2008-06-05 2:01 ` Nick Piggin
2008-06-05 2:01 ` Nick Piggin
2008-06-06 21:35 ` Peter Zijlstra
2008-06-06 21:35 ` Peter Zijlstra
2008-05-29 12:20 ` [patch 2/5] mm: introduce get_user_pages_fast npiggin
2008-05-29 12:20 ` npiggin
2008-06-09 10:29 ` Andrew Morton
2008-06-09 10:29 ` Andrew Morton
2008-05-29 12:20 ` [patch 3/5] x86: lockless get_user_pages_fast npiggin
2008-05-29 12:20 ` npiggin
2008-05-29 17:20 ` Dave Kleikamp
2008-05-29 17:20 ` Dave Kleikamp
2008-05-30 0:55 ` Nick Piggin
2008-05-30 0:55 ` Nick Piggin
2008-06-02 10:15 ` Nick Piggin
2008-06-02 10:15 ` Nick Piggin
2008-06-02 11:28 ` Stephen Rothwell
2008-06-03 2:34 ` Nick Piggin
2008-06-03 2:34 ` Nick Piggin
2008-06-03 4:46 ` Stephen Rothwell
2008-05-29 12:20 ` [patch 4/5] dio: use get_user_pages_fast npiggin
2008-05-29 12:20 ` npiggin
2008-05-29 12:20 ` [patch 5/5] splice: " npiggin
2008-05-29 12:20 ` npiggin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20080602165847.dd19ddb1.akpm@linux-foundation.org \
--to=akpm@linux-foundation.org \
--cc=apw@shadowen.org \
--cc=linux-arch@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=npiggin@suse.de \
--cc=shaggy@austin.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.