From: Evgeniy Polyakov <johnpol@2ka.mipt.ru>
To: Kim Phillips <kim.phillips@freescale.com>
Cc: Scott Wood <scottwood@freescale.com>,
linuxppc-dev@ozlabs.org, mr.scada@gmail.com,
linux-crypto@vger.kernel.org, herbert@gondor.apana.org.au
Subject: Re: [PATCH 2/2] talitos: Freescale integrated security engine (SEC) driver
Date: Mon, 2 Jun 2008 21:57:51 +0400 [thread overview]
Message-ID: <20080602175751.GA7807@2ka.mipt.ru> (raw)
In-Reply-To: <20080602115021.cdda8647.kim.phillips@freescale.com>
On Mon, Jun 02, 2008 at 11:50:21AM -0500, Kim Phillips (kim.phillips@freescale.com) wrote:
> > But can it be changed? You write to it without lock, but read under the
> > one (different for each channel though), so it attracted attention.
>
> can you point where in the code your concern is?
talitos_submit() writes to hdr (initially I think?) without locks.
It is read in flush_channel() under tail lock, but then it is dropped,
so I rised a question, if it can be modified during that time, since if
it can, status value, calculated from it, can be different and thus
error check result can be false. Or this is not an issue?
--
Evgeniy Polyakov
next prev parent reply other threads:[~2008-06-02 17:58 UTC|newest]
Thread overview: 23+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-05-29 19:12 [PATCH 2/2] talitos: Freescale integrated security engine (SEC) driver Kim Phillips
2008-05-29 19:12 ` Kim Phillips
2008-05-30 18:09 ` Evgeniy Polyakov
2008-05-30 18:09 ` Evgeniy Polyakov
2008-05-30 19:36 ` Kim Phillips
2008-05-30 19:36 ` Kim Phillips
2008-05-30 19:41 ` Scott Wood
2008-05-30 20:13 ` Evgeniy Polyakov
2008-05-30 20:13 ` Evgeniy Polyakov
2008-05-30 20:16 ` Kim Phillips
2008-05-30 20:19 ` Scott Wood
2008-05-30 20:35 ` Kim Phillips
2008-05-30 20:36 ` Scott Wood
2008-05-30 20:48 ` Kim Phillips
2008-05-30 21:12 ` Evgeniy Polyakov
2008-05-30 22:19 ` Kim Phillips
2008-05-31 9:59 ` Evgeniy Polyakov
2008-06-02 14:27 ` Kim Phillips
2008-06-02 16:00 ` Evgeniy Polyakov
2008-06-02 16:50 ` Kim Phillips
2008-06-02 17:57 ` Evgeniy Polyakov [this message]
2008-06-02 19:06 ` Kim Phillips
2008-06-03 1:24 ` Evgeniy Polyakov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20080602175751.GA7807@2ka.mipt.ru \
--to=johnpol@2ka.mipt.ru \
--cc=herbert@gondor.apana.org.au \
--cc=kim.phillips@freescale.com \
--cc=linux-crypto@vger.kernel.org \
--cc=linuxppc-dev@ozlabs.org \
--cc=mr.scada@gmail.com \
--cc=scottwood@freescale.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.