From: Evgeniy Polyakov <johnpol@2ka.mipt.ru>
To: Scott Wood <scottwood@freescale.com>
Cc: Kim Phillips <kim.phillips@freescale.com>,
linuxppc-dev@ozlabs.org, mr.scada@gmail.com,
linux-crypto@vger.kernel.org, herbert@gondor.apana.org.au
Subject: Re: [PATCH 2/2] talitos: Freescale integrated security engine (SEC) driver
Date: Sat, 31 May 2008 00:13:52 +0400 [thread overview]
Message-ID: <20080530201352.GA26698@2ka.mipt.ru> (raw)
In-Reply-To: <4840585D.8050805@freescale.com>
On Fri, May 30, 2008 at 02:41:17PM -0500, Scott Wood (scottwood@freescale.com) wrote:
> >>Don't you want to protect against simultaneous access to register space
> >>from different CPUs? Or it is single processor board only?
> >
> >Doesn't linux mask the IRQ line for the interrupt currently being
> >serviced, and on all processors?
>
> Yes. Could there be interference from non-interrupt driver code on
> another cpu (or interrupted code), though?
Yes, that register space can be assigned from non-interrupt path on
different cpu. I saw spin_lock_irqsave() is used in some other places,
but not in interrupt handler itself.
--
Evgeniy Polyakov
WARNING: multiple messages have this Message-ID (diff)
From: Evgeniy Polyakov <johnpol@2ka.mipt.ru>
To: Scott Wood <scottwood@freescale.com>
Cc: linuxppc-dev@ozlabs.org, mr.scada@gmail.com,
linux-crypto@vger.kernel.org, herbert@gondor.apana.org.au
Subject: Re: [PATCH 2/2] talitos: Freescale integrated security engine (SEC) driver
Date: Sat, 31 May 2008 00:13:52 +0400 [thread overview]
Message-ID: <20080530201352.GA26698@2ka.mipt.ru> (raw)
In-Reply-To: <4840585D.8050805@freescale.com>
On Fri, May 30, 2008 at 02:41:17PM -0500, Scott Wood (scottwood@freescale.com) wrote:
> >>Don't you want to protect against simultaneous access to register space
> >>from different CPUs? Or it is single processor board only?
> >
> >Doesn't linux mask the IRQ line for the interrupt currently being
> >serviced, and on all processors?
>
> Yes. Could there be interference from non-interrupt driver code on
> another cpu (or interrupted code), though?
Yes, that register space can be assigned from non-interrupt path on
different cpu. I saw spin_lock_irqsave() is used in some other places,
but not in interrupt handler itself.
--
Evgeniy Polyakov
next prev parent reply other threads:[~2008-05-30 20:14 UTC|newest]
Thread overview: 23+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-05-29 19:12 [PATCH 2/2] talitos: Freescale integrated security engine (SEC) driver Kim Phillips
2008-05-29 19:12 ` Kim Phillips
2008-05-30 18:09 ` Evgeniy Polyakov
2008-05-30 18:09 ` Evgeniy Polyakov
2008-05-30 19:36 ` Kim Phillips
2008-05-30 19:36 ` Kim Phillips
2008-05-30 19:41 ` Scott Wood
2008-05-30 20:13 ` Evgeniy Polyakov [this message]
2008-05-30 20:13 ` Evgeniy Polyakov
2008-05-30 20:16 ` Kim Phillips
2008-05-30 20:19 ` Scott Wood
2008-05-30 20:35 ` Kim Phillips
2008-05-30 20:36 ` Scott Wood
2008-05-30 20:48 ` Kim Phillips
2008-05-30 21:12 ` Evgeniy Polyakov
2008-05-30 22:19 ` Kim Phillips
2008-05-31 9:59 ` Evgeniy Polyakov
2008-06-02 14:27 ` Kim Phillips
2008-06-02 16:00 ` Evgeniy Polyakov
2008-06-02 16:50 ` Kim Phillips
2008-06-02 17:57 ` Evgeniy Polyakov
2008-06-02 19:06 ` Kim Phillips
2008-06-03 1:24 ` Evgeniy Polyakov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20080530201352.GA26698@2ka.mipt.ru \
--to=johnpol@2ka.mipt.ru \
--cc=herbert@gondor.apana.org.au \
--cc=kim.phillips@freescale.com \
--cc=linux-crypto@vger.kernel.org \
--cc=linuxppc-dev@ozlabs.org \
--cc=mr.scada@gmail.com \
--cc=scottwood@freescale.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.