From: Joel Becker <Joel.Becker@oracle.com>
To: Louis Rilling <Louis.Rilling@kerlabs.com>
Cc: ocfs2-devel@oss.oracle.com, linux-kernel@vger.kernel.org
Subject: [Ocfs2-devel] [RFC][PATCH 4/4] configfs: Make multiple default_group destructions lockdep friendly
Date: Mon, 2 Jun 2008 16:07:21 -0700 [thread overview]
Message-ID: <20080602230721.GD19500@mail.oracle.com> (raw)
In-Reply-To: <4836F48A.70008@kerlabs.com>
A couple comments.
First, put a BUG_ON() where you have BAD BAD BAD - we shouldn't
be creating a depth we can't delete.
> @@ -392,6 +437,10 @@ static int configfs_detach_prep(struct d
> * deep nesting of default_groups
> */
> ret = configfs_detach_prep(sd->s_dentry);
> + /* Update parent's lock_level so that remaining
> + * sibling children keep on globally increasing
> + * lock_level */
> + copy_dirent_lock_level(sd, parent_sd);
> if (!ret)
> continue;
> } else
I'm not sure I get this hunk. If our parent was 1 and we are 2,
we are copying 2 to our parent so the parent can only have other
children at 3?
Joel
--
Life's Little Instruction Book #267
"Lie on your back and look at the stars."
Joel Becker
Principal Software Developer
Oracle
E-mail: joel.becker at oracle.com
Phone: (650) 506-8127
WARNING: multiple messages have this Message-ID (diff)
From: Joel Becker <Joel.Becker@oracle.com>
To: Louis Rilling <Louis.Rilling@kerlabs.com>
Cc: ocfs2-devel@oss.oracle.com, linux-kernel@vger.kernel.org
Subject: Re: [RFC][PATCH 4/4] configfs: Make multiple default_group destructions lockdep friendly
Date: Mon, 2 Jun 2008 16:07:21 -0700 [thread overview]
Message-ID: <20080602230721.GD19500@mail.oracle.com> (raw)
In-Reply-To: <4836F48A.70008@kerlabs.com>
A couple comments.
First, put a BUG_ON() where you have BAD BAD BAD - we shouldn't
be creating a depth we can't delete.
> @@ -392,6 +437,10 @@ static int configfs_detach_prep(struct d
> * deep nesting of default_groups
> */
> ret = configfs_detach_prep(sd->s_dentry);
> + /* Update parent's lock_level so that remaining
> + * sibling children keep on globally increasing
> + * lock_level */
> + copy_dirent_lock_level(sd, parent_sd);
> if (!ret)
> continue;
> } else
I'm not sure I get this hunk. If our parent was 1 and we are 2,
we are copying 2 to our parent so the parent can only have other
children at 3?
Joel
--
Life's Little Instruction Book #267
"Lie on your back and look at the stars."
Joel Becker
Principal Software Developer
Oracle
E-mail: joel.becker@oracle.com
Phone: (650) 506-8127
next prev parent reply other threads:[~2008-06-02 23:07 UTC|newest]
Thread overview: 34+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-05-22 11:40 [Ocfs2-devel] [RFC][PATCH 0/4] configfs: Make nested default groups lockdep-friendly v2 Louis Rilling
2008-05-22 11:40 ` Louis Rilling
2008-05-22 11:40 ` [Ocfs2-devel] [RFC][PATCH 1/4] Prepare i_mutex lockdep subclasses for locking of variable path lengths Louis Rilling
2008-05-22 11:40 ` Louis Rilling
2008-05-22 11:40 ` [Ocfs2-devel] [RFC][PATCH 2/4] Prepare vfs_rmdir() for further nested i_mutex locking Louis Rilling
2008-05-22 11:40 ` Louis Rilling
2008-05-22 11:40 ` [Ocfs2-devel] [RFC][PATCH 3/4] configfs: Make nested default groups creations lockdep-friendly Louis Rilling
2008-05-22 11:40 ` Louis Rilling
2008-05-22 11:40 ` [Ocfs2-devel] [RFC][PATCH 4/4] configfs: Make multiple default_group destructions lockdep friendly Louis Rilling
2008-05-22 11:40 ` Louis Rilling
2008-05-23 16:44 ` [Ocfs2-devel] " Louis Rilling
2008-05-23 16:44 ` Louis Rilling
2008-06-02 23:07 ` Joel Becker [this message]
2008-06-02 23:07 ` Joel Becker
2008-06-03 16:00 ` [Ocfs2-devel] " Louis Rilling
2008-06-03 16:00 ` Louis Rilling
2008-06-06 23:01 ` [Ocfs2-devel] " Joel Becker
2008-06-06 23:01 ` Joel Becker
2008-06-09 11:03 ` [Ocfs2-devel] " Louis Rilling
2008-06-09 11:03 ` Louis Rilling
2008-06-09 12:54 ` [Ocfs2-devel] [BUG] deadlock between configfs_rmdir() and sys_rename() (WAS Re: [RFC][PATCH 4/4] configfs: Make multiple default_group) " Louis Rilling
2008-06-09 12:54 ` Louis Rilling
2008-06-10 1:58 ` [Ocfs2-devel] " Joel Becker
2008-06-10 1:58 ` Joel Becker
2008-06-10 10:14 ` [Ocfs2-devel] " Louis Rilling
2008-06-10 10:14 ` Louis Rilling
2008-06-10 17:36 ` [Ocfs2-devel] " Joel Becker
2008-06-10 17:36 ` Joel Becker
2008-06-11 14:10 ` [Ocfs2-devel] " Louis Rilling
2008-06-11 14:10 ` Louis Rilling
2008-06-11 17:30 ` [Ocfs2-devel] " Louis Rilling
2008-06-11 17:30 ` Louis Rilling
2008-06-11 21:15 ` [Ocfs2-devel] " Joel Becker
2008-06-11 21:15 ` Joel Becker
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20080602230721.GD19500@mail.oracle.com \
--to=joel.becker@oracle.com \
--cc=Louis.Rilling@kerlabs.com \
--cc=linux-kernel@vger.kernel.org \
--cc=ocfs2-devel@oss.oracle.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.