All of lore.kernel.org
 help / color / mirror / Atom feed
From: Christoph Hellwig <hch@lst.de>
To: Eric Sandeen <sandeen@sandeen.net>
Cc: Christoph Hellwig <hch@lst.de>, xfs@oss.sgi.com
Subject: Re: [PATCH] fix mount option parsing in remount
Date: Tue, 3 Jun 2008 15:05:34 +0200	[thread overview]
Message-ID: <20080603130534.GA8694@lst.de> (raw)
In-Reply-To: <48453E5D.8050301@sandeen.net>

On Tue, Jun 03, 2008 at 07:51:41AM -0500, Eric Sandeen wrote:
> Maybe expand this a little:
> 
> /*
>  * Today only the barrier/nobarrier xfs mount options are handled
>  * on remount.  This table should be expanded to cover all options,
>  * and used for the initial mount path, too.
>  */
> 
> ... I'd also like this for the mount path because for example:
> 
> mount -t xfs -o barrier=0 /dev/blah /mnt/foo
> 
> works... but does not turn off barriers.
> 
> So as a first step/example this looks ok but I'd sure like to see it
> extended soon.  Maybe when I'm bored... :)

Doh.  But yeah, mount path should be switched over soon.  I alredy
posted the patches to kill the xfs_mount_args gunk which have been on
the list for a while and happily ignored, and switching to the parser.h
helper ontop of that is quite easy.  I just want to wait a little bit
so that any problems with the previous patch are shaked out before the
new one gets added.

  reply	other threads:[~2008-06-03 13:04 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-05-18 15:35 [PATCH] fix mount option parsing in remount Christoph Hellwig
2008-06-03  8:00 ` Christoph Hellwig
2008-06-27 13:11   ` Christoph Hellwig
2008-06-27 14:49     ` Eric Sandeen
2008-06-03 12:51 ` Eric Sandeen
2008-06-03 13:05   ` Christoph Hellwig [this message]
2008-06-30  6:21 ` Timothy Shimmin
2008-06-30 16:18   ` Christoph Hellwig

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20080603130534.GA8694@lst.de \
    --to=hch@lst.de \
    --cc=sandeen@sandeen.net \
    --cc=xfs@oss.sgi.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.