From: Jesse Barnes <jbarnes@virtuousgeek.org>
To: Andrew Morton <akpm@linux-foundation.org>
Cc: Andres Salomon <dilinger@queued.net>,
linux-kernel@vger.kernel.org, mingo@redhat.com, hpa@zytor.com,
tglx@linutronix.de, rmh@aybabtu.com
Subject: Re: [PATCH] OLPC: pci: fix up PCI stuff so that PCI_GOANY supports OLPC
Date: Thu, 5 Jun 2008 13:34:32 -0700 [thread overview]
Message-ID: <200806051334.32260.jbarnes@virtuousgeek.org> (raw)
In-Reply-To: <20080605124220.5a6245ab.akpm@linux-foundation.org>
On Thursday, June 05, 2008 12:42 pm Andrew Morton wrote:
> On Thu, 5 Jun 2008 15:29:14 -0400
>
> Andres Salomon <dilinger@queued.net> wrote:
> > Previously, one would have to specifically choose CONFIG_OLPC and
> > CONFIG_PCI_GOOLPC in order to enable PCI_OLPC. That doesn't really
> > work for distro kernels, so this patch allows one to choose
> > CONFIG_OLPC and CONFIG_PCI_GOANY in order to build in OLPC support in
> > a generic kernel (as requested by Robert Millan).
> >
> > This also moves GOOLPC before GOANY in the menuconfig list.
> >
> > Finally, make pci_access_init return early if we detect OLPC hardware.
> > There's no need to continue probing stuff, and pci_pcbios_init
> > specifically trashes our settings (we didn't run into that before
> > because PCI_GOANY wasn't supported).
> >
> > It would be great if we could sneak this in for 2.6.26.. *cough* :)
>
> It looks harmless enough.
>
> > ---
> > arch/x86/Kconfig | 11 +++++------
> > arch/x86/pci/init.c | 3 ++-
> > arch/x86/pci/olpc.c | 5 +++--
> > arch/x86/pci/pci.h | 2 +-
>
> But I never know whether arch/x86/pci is a Jesse thing or an Ingo
> thing. Usual answer: it's an everyone thing and we all make a big mess ;)
Heh, yeah I've been taking quite a few x86 PCI patches (Ingo actually has a
queue of them for me now), so I can pick this one up and put it in what I
hope will be my final 2.6.26 pull request.
Jesse
next prev parent reply other threads:[~2008-06-05 20:35 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-06-05 19:29 [PATCH] OLPC: pci: fix up PCI stuff so that PCI_GOANY supports OLPC Andres Salomon
2008-06-05 19:42 ` Andrew Morton
2008-06-05 20:34 ` Jesse Barnes [this message]
2008-06-05 20:49 ` Thomas Gleixner
2008-06-05 20:07 ` Randy.Dunlap
2008-06-05 20:27 ` Andres Salomon
2008-06-06 11:05 ` Pavel Machek
2008-06-06 12:46 ` Andres Salomon
2008-06-06 13:09 ` Robert Millan
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=200806051334.32260.jbarnes@virtuousgeek.org \
--to=jbarnes@virtuousgeek.org \
--cc=akpm@linux-foundation.org \
--cc=dilinger@queued.net \
--cc=hpa@zytor.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@redhat.com \
--cc=rmh@aybabtu.com \
--cc=tglx@linutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.