From: Andres Salomon <dilinger@queued.net>
To: "Randy.Dunlap" <rdunlap@xenotime.net>
Cc: Andrew Morton <akpm@linux-foundation.org>,
linux-kernel@vger.kernel.org, mingo@redhat.com,
"H. Peter Anvin" <hpa@zytor.com>,
tglx@linutronix.de, rmh@aybabtu.com
Subject: Re: [PATCH] OLPC: pci: fix up PCI stuff so that PCI_GOANY supports OLPC
Date: Thu, 5 Jun 2008 16:27:24 -0400 [thread overview]
Message-ID: <20080605162724.51b9cb7f@ephemeral> (raw)
In-Reply-To: <Pine.LNX.4.64.0806051307040.30305@shark.he.net>
On Thu, 5 Jun 2008 13:07:35 -0700 (PDT)
"Randy.Dunlap" <rdunlap@xenotime.net> wrote:
> On Thu, 5 Jun 2008, Andres Salomon wrote:
>
> > Previously, one would have to specifically choose CONFIG_OLPC and
> > CONFIG_PCI_GOOLPC in order to enable PCI_OLPC. That doesn't really
> > work for distro kernels, so this patch allows one to choose
> > CONFIG_OLPC and CONFIG_PCI_GOANY in order to build in OLPC support
> > in a generic kernel (as requested by Robert Millan).
> >
> > This also moves GOOLPC before GOANY in the menuconfig list.
>
> Please say why... (for above)
>
The options above GOANY are included in GOANY.
Previously, GOANY did not support GOOLPC, so GOOLPC was listed after it.
Now that GOANY supports GOOLPC, it can be listed above w/ the others.
Plus, _I_ think it looks nicer. :) That hunk can easily be removed from
the patch if others disagree.
next prev parent reply other threads:[~2008-06-05 20:21 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-06-05 19:29 [PATCH] OLPC: pci: fix up PCI stuff so that PCI_GOANY supports OLPC Andres Salomon
2008-06-05 19:42 ` Andrew Morton
2008-06-05 20:34 ` Jesse Barnes
2008-06-05 20:49 ` Thomas Gleixner
2008-06-05 20:07 ` Randy.Dunlap
2008-06-05 20:27 ` Andres Salomon [this message]
2008-06-06 11:05 ` Pavel Machek
2008-06-06 12:46 ` Andres Salomon
2008-06-06 13:09 ` Robert Millan
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20080605162724.51b9cb7f@ephemeral \
--to=dilinger@queued.net \
--cc=akpm@linux-foundation.org \
--cc=hpa@zytor.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@redhat.com \
--cc=rdunlap@xenotime.net \
--cc=rmh@aybabtu.com \
--cc=tglx@linutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.