All of lore.kernel.org
 help / color / mirror / Atom feed
From: Andrea Arcangeli <andrea@qumranet.com>
To: "Paul E. McKenney" <paulmck@linux.vnet.ibm.com>
Cc: Andrew Morton <akpm@linux-foundation.org>,
	Linus Torvalds <torvalds@linux-foundation.org>,
	Christoph Lameter <clameter@sgi.com>,
	Jack Steiner <steiner@sgi.com>, Robin Holt <holt@sgi.com>,
	Nick Piggin <npiggin@suse.de>,
	Peter Zijlstra <a.p.zijlstra@chello.nl>,
	kvm-devel@lists.sourceforge.net,
	Kanoj Sarcar <kanojsarcar@yahoo.com>,
	Roland Dreier <rdreier@cisco.com>,
	Steve Wise <swise@opengridcomputing.com>,
	linux-kernel@vger.kernel.org, Avi Kivity <avi@qumranet.com>,
	linux-mm@kvack.org, general@lists.openfabrics.org,
	Hugh Dickins <hugh@veritas.com>,
	Rusty Russell <rusty@rustcorp.com.au>,
	Anthony Liguori <aliguori@us.ibm.com>,
	Chris Wright <chrisw@redhat.com>,
	Marcelo Tosatti <marcelo@kvack.org>,
	Eric Dumazet <dada1@cosmosbay.com>
Subject: Re: [PATCH 001/001] mmu-notifier-core v17
Date: Thu, 5 Jun 2008 18:51:04 +0200	[thread overview]
Message-ID: <20080605165104.GI15502@duo.random> (raw)
In-Reply-To: <20080516190752.GK11333@linux.vnet.ibm.com>

On Fri, May 16, 2008 at 12:07:52PM -0700, Paul E. McKenney wrote:
> The hlist_del_init_rcu() primitive looks good.
> 
> The rest of the RCU code looks fine assuming that "mn->ops->release()"
> either does call_rcu() to defer actual removal, or that the actual
> removal is deferred until after mmu_notifier_release() returns.

Yes, actual removal is deferred until after mmu_notifier_release()
returns.

> Acked-by: Paul E. McKenney <paulmck@linux.vnet.ibm.com>

Thanks for the review Paul! I should also have added your precious
Acked-by to the 1/3 and 3/3 but the important is the ack by email ;)

WARNING: multiple messages have this Message-ID (diff)
From: Andrea Arcangeli <andrea@qumranet.com>
To: "Paul E. McKenney" <paulmck@linux.vnet.ibm.com>
Cc: Andrew Morton <akpm@linux-foundation.org>,
	Linus Torvalds <torvalds@linux-foundation.org>,
	Christoph Lameter <clameter@sgi.com>,
	Jack Steiner <steiner@sgi.com>, Robin Holt <holt@sgi.com>,
	Nick Piggin <npiggin@suse.de>,
	Peter Zijlstra <a.p.zijlstra@chello.nl>,
	kvm-devel@lists.sourceforge.net,
	Kanoj Sarcar <kanojsarcar@yahoo.com>,
	Roland Dreier <rdreier@cisco.com>,
	Steve Wise <swise@opengridcomputing.com>,
	linux-kernel@vger.kernel.org, Avi Kivity <avi@qumranet.com>,
	linux-mm@kvack.org, general@lists.openfabrics.org,
	Hugh Dickins <hugh@veritas.com>,
	Rusty Russell <rusty@rustcorp.com.au>,
	Anthony Liguori <aliguori@us.ibm.com>,
	Chris Wright <chrisw@redhat.com>,
	Marcelo Tosatti <marcelo@kvack.org>,
	Eric Dumazet <dada1@cosmosbay.com>
Subject: Re: [PATCH 001/001] mmu-notifier-core v17
Date: Thu, 5 Jun 2008 18:51:04 +0200	[thread overview]
Message-ID: <20080605165104.GI15502@duo.random> (raw)
In-Reply-To: <20080516190752.GK11333@linux.vnet.ibm.com>

On Fri, May 16, 2008 at 12:07:52PM -0700, Paul E. McKenney wrote:
> The hlist_del_init_rcu() primitive looks good.
> 
> The rest of the RCU code looks fine assuming that "mn->ops->release()"
> either does call_rcu() to defer actual removal, or that the actual
> removal is deferred until after mmu_notifier_release() returns.

Yes, actual removal is deferred until after mmu_notifier_release()
returns.

> Acked-by: Paul E. McKenney <paulmck@linux.vnet.ibm.com>

Thanks for the review Paul! I should also have added your precious
Acked-by to the 1/3 and 3/3 but the important is the ack by email ;)

--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org.  For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>

  reply	other threads:[~2008-06-05 16:51 UTC|newest]

Thread overview: 15+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-05-09 19:32 [PATCH 001/001] mmu-notifier-core v17 Andrea Arcangeli
2008-05-09 19:32 ` Andrea Arcangeli, Andrea Arcangeli
2008-05-09 19:32 ` [ofa-general] " Andrea Arcangeli
2008-05-12 20:01 ` Jack Steiner
2008-05-12 20:01   ` Jack Steiner
2008-05-16 19:07 ` Paul E. McKenney
2008-05-16 19:07   ` Paul E. McKenney
2008-05-16 19:07   ` [ofa-general] " Paul E. McKenney
2008-06-05 16:51   ` Andrea Arcangeli [this message]
2008-06-05 16:51     ` Andrea Arcangeli
2008-06-03 16:26 ` Linus Torvalds
2008-06-03 16:26   ` Linus Torvalds
2008-06-03 17:35   ` Andrea Arcangeli
2008-06-03 17:35     ` Andrea Arcangeli
2008-06-03 17:35   ` Andrea Arcangeli

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20080605165104.GI15502@duo.random \
    --to=andrea@qumranet.com \
    --cc=a.p.zijlstra@chello.nl \
    --cc=akpm@linux-foundation.org \
    --cc=aliguori@us.ibm.com \
    --cc=avi@qumranet.com \
    --cc=chrisw@redhat.com \
    --cc=clameter@sgi.com \
    --cc=dada1@cosmosbay.com \
    --cc=general@lists.openfabrics.org \
    --cc=holt@sgi.com \
    --cc=hugh@veritas.com \
    --cc=kanojsarcar@yahoo.com \
    --cc=kvm-devel@lists.sourceforge.net \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-mm@kvack.org \
    --cc=marcelo@kvack.org \
    --cc=npiggin@suse.de \
    --cc=paulmck@linux.vnet.ibm.com \
    --cc=rdreier@cisco.com \
    --cc=rusty@rustcorp.com.au \
    --cc=steiner@sgi.com \
    --cc=swise@opengridcomputing.com \
    --cc=torvalds@linux-foundation.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.