From: Robert Millan <rmh@aybabtu.com>
To: The development of GRUB 2 <grub-devel@gnu.org>
Subject: Re: [PATCH] missleading function name
Date: Thu, 5 Jun 2008 23:11:16 +0200 [thread overview]
Message-ID: <20080605211115.GB13515@thorin> (raw)
In-Reply-To: <1212631708.26365.26.camel@dv>
On Wed, Jun 04, 2008 at 10:08:28PM -0400, Pavel Roskin wrote:
> On Thu, 2008-06-05 at 01:30 +0200, Robert Millan wrote:
> > IMHO the name of this function is highly misleading. It makes one think
> > it just checks something, but it actually modifies our variables. I think
> > "adjust" would fit better than "check".
>
> But nothing can be better that a good old-fashioned connect before the
> function.
What do you mean?
> It looks like it does several things:
>
> 1) it makes sectors disk relative from partition relative (I guess
> that's what grub-emu forgets)
Ah, that explains it. Maybe the code in util/biosdisk.c comes from a time
in which kern/disk.c didn't do this.
--
Robert Millan
<GPLv2> I know my rights; I want my phone call!
<DRM> What good is a phone call… if you are unable to speak?
(as seen on /.)
next prev parent reply other threads:[~2008-06-05 21:11 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-06-04 23:30 [PATCH] missleading function name Robert Millan
2008-06-05 2:08 ` Pavel Roskin
2008-06-05 21:11 ` Robert Millan [this message]
2008-06-05 21:14 ` Pavel Roskin
2008-06-08 19:47 ` Robert Millan
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20080605211115.GB13515@thorin \
--to=rmh@aybabtu.com \
--cc=grub-devel@gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.