From: Pavel Roskin <proski@gnu.org>
To: The development of GRUB 2 <grub-devel@gnu.org>
Subject: Re: [PATCH] missleading function name
Date: Thu, 05 Jun 2008 17:14:59 -0400 [thread overview]
Message-ID: <1212700499.30431.8.camel@dv> (raw)
In-Reply-To: <20080605211115.GB13515@thorin>
On Thu, 2008-06-05 at 23:11 +0200, Robert Millan wrote:
> On Wed, Jun 04, 2008 at 10:08:28PM -0400, Pavel Roskin wrote:
> > On Thu, 2008-06-05 at 01:30 +0200, Robert Millan wrote:
> > > IMHO the name of this function is highly misleading. It makes one think
> > > it just checks something, but it actually modifies our variables. I think
> > > "adjust" would fit better than "check".
> >
> > But nothing can be better that a good old-fashioned connect before the
> > function.
>
> What do you mean?
I mean "comment", sorry.
--
Regards,
Pavel Roskin
next prev parent reply other threads:[~2008-06-05 21:15 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-06-04 23:30 [PATCH] missleading function name Robert Millan
2008-06-05 2:08 ` Pavel Roskin
2008-06-05 21:11 ` Robert Millan
2008-06-05 21:14 ` Pavel Roskin [this message]
2008-06-08 19:47 ` Robert Millan
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1212700499.30431.8.camel@dv \
--to=proski@gnu.org \
--cc=grub-devel@gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.