* [PATCH] MTD: NAND: fsl_elbc_nand: fix section mismatch between probe and remove
@ 2008-06-06 14:59 Anton Vorontsov
2008-06-06 15:10 ` Scott Wood
0 siblings, 1 reply; 2+ messages in thread
From: Anton Vorontsov @ 2008-06-06 14:59 UTC (permalink / raw)
To: David Woodhouse; +Cc: Scott Wood, linux-mtd
WARNING: drivers/mtd/nand/built-in.o(.devinit.text+0x114): Section mismatch
in reference from the function fsl_elbc_ctrl_probe() to the function
.devexit.text:fsl_elbc_ctrl_remove()
__devinit functions should not call functions with __devexit. Since probe
function calls remove in case of errors, we want to remove __devexit
attribute from it.
Signed-off-by: Anton Vorontsov <avorontsov@ru.mvista.com>
---
drivers/mtd/nand/fsl_elbc_nand.c | 4 ++--
1 files changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/mtd/nand/fsl_elbc_nand.c b/drivers/mtd/nand/fsl_elbc_nand.c
index 4b69aac..1b06d29 100644
--- a/drivers/mtd/nand/fsl_elbc_nand.c
+++ b/drivers/mtd/nand/fsl_elbc_nand.c
@@ -917,7 +917,7 @@ static int __devinit fsl_elbc_ctrl_init(struct fsl_elbc_ctrl *ctrl)
return 0;
}
-static int __devexit fsl_elbc_ctrl_remove(struct of_device *ofdev)
+static int fsl_elbc_ctrl_remove(struct of_device *ofdev)
{
struct fsl_elbc_ctrl *ctrl = dev_get_drvdata(&ofdev->dev);
int i;
@@ -1041,7 +1041,7 @@ static struct of_platform_driver fsl_elbc_ctrl_driver = {
},
.match_table = fsl_elbc_match,
.probe = fsl_elbc_ctrl_probe,
- .remove = __devexit_p(fsl_elbc_ctrl_remove),
+ .remove = fsl_elbc_ctrl_remove,
};
static int __init fsl_elbc_init(void)
--
1.5.5.1
^ permalink raw reply related [flat|nested] 2+ messages in thread* Re: [PATCH] MTD: NAND: fsl_elbc_nand: fix section mismatch between probe and remove
2008-06-06 14:59 [PATCH] MTD: NAND: fsl_elbc_nand: fix section mismatch between probe and remove Anton Vorontsov
@ 2008-06-06 15:10 ` Scott Wood
0 siblings, 0 replies; 2+ messages in thread
From: Scott Wood @ 2008-06-06 15:10 UTC (permalink / raw)
To: Anton Vorontsov; +Cc: linux-mtd, David Woodhouse
On Fri, Jun 06, 2008 at 06:59:40PM +0400, Anton Vorontsov wrote:
> WARNING: drivers/mtd/nand/built-in.o(.devinit.text+0x114): Section mismatch
> in reference from the function fsl_elbc_ctrl_probe() to the function
> .devexit.text:fsl_elbc_ctrl_remove()
>
> __devinit functions should not call functions with __devexit. Since probe
> function calls remove in case of errors, we want to remove __devexit
> attribute from it.
>
> Signed-off-by: Anton Vorontsov <avorontsov@ru.mvista.com>
Acked-by: Scott Wood <scottwood@freescale.com>
-Scott
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2008-06-06 15:10 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2008-06-06 14:59 [PATCH] MTD: NAND: fsl_elbc_nand: fix section mismatch between probe and remove Anton Vorontsov
2008-06-06 15:10 ` Scott Wood
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.