All of lore.kernel.org
 help / color / mirror / Atom feed
From: "S.Çağlar Onur" <caglar@pardus.org.tr>
To: linux-kernel@vger.kernel.org
Cc: "Linus Torvalds" <torvalds@linux-foundation.org>,
	"Frank Seidel" <fseidel@suse.de>,
	"OGAWA Hirofumi" <hirofumi@mail.parknet.co.jp>,
	"Onur Küçük" <onur@pardus.org.tr>
Subject: [PATCH] include/linux/msdos_fs.h: Cleanup include/linux/msdos_fs.h for userspace.
Date: Sun, 8 Jun 2008 21:16:48 +0300	[thread overview]
Message-ID: <200806082116.50355.caglar@pardus.org.tr> (raw)

include/linux/msdos_fs.h header should use __u## rather than u## types else any userspace code (like syslinux) includes that header fails to compile like following;

[...]
gcc -Wp,-MT,bootsect_bin.o,-MMD,.bootsect_bin.o.d -W -Wall -D_FILE_OFFSET_BITS=64 -g -Os -I. -I.. -I../libinstaller -c -o bootsect_bin.o ../bootsect_bin.c
gcc -Wp,-MT,ldlinux_bin.o,-MMD,.ldlinux_bin.o.d -W -Wall -D_FILE_OFFSET_BITS=64 -g -Os -I. -I.. -I../libinstaller -c -o ldlinux_bin.o ../ldlinux_bin.c
In file included from syslinux.c:52:
/usr/include/linux/msdos_fs.h:61: error: expected ')' before 'media'
[...]

Noticed by Onur Küçük <onur@pardus.org.tr>

Cc: Frank Seidel <fseidel@suse.de>
CC: OGAWA Hirofumi <hirofumi@mail.parknet.co.jp>
CC: Onur Küçük <onur@pardus.org.tr>

Signed-off-by: S.Çağlar Onur <caglar@pardus.org.tr>

 include/linux/msdos_fs.h |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)

diff --git a/include/linux/msdos_fs.h b/include/linux/msdos_fs.h
index b03b274..3825b1c 100644
--- a/include/linux/msdos_fs.h
+++ b/include/linux/msdos_fs.h
@@ -58,7 +58,7 @@
 #define MSDOS_DOTDOT	"..         "	/* "..", padded to MSDOS_NAME chars */
 
 /* media of boot sector */
-static inline int fat_valid_media(u8 media)
+static inline int fat_valid_media(__u8 media)
 {
 	return 0xf8 <= media || media == 0xf0;
 }

Cheers
-- 
S.Çağlar Onur <caglar@pardus.org.tr>
http://cekirdek.pardus.org.tr/~caglar/

Linux is like living in a teepee. No Windows, no Gates and an Apache in house!

             reply	other threads:[~2008-06-08 18:17 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-06-08 18:16 S.Çağlar Onur [this message]
2008-06-08 18:36 ` [PATCH] include/linux/msdos_fs.h: Cleanup include/linux/msdos_fs.h for userspace OGAWA Hirofumi
2008-06-08 18:43 ` [2.6.26 patch] fat_valid_media() isn't " Adrian Bunk
2008-06-08 18:55   ` OGAWA Hirofumi
2008-06-09  1:14     ` H. Peter Anvin
2008-06-09  4:12       ` OGAWA Hirofumi
2008-06-09  4:41         ` H. Peter Anvin
2008-06-09  8:05         ` Adrian Bunk
2008-06-09 22:26         ` [2.6 patch] fat/dir.c: switch to struct __fat_fs_dirent Adrian Bunk
2008-06-09 23:12           ` OGAWA Hirofumi
2008-06-09 22:27       ` [2.6 patch] remove the in-kernel struct dirent{,64} Adrian Bunk

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=200806082116.50355.caglar@pardus.org.tr \
    --to=caglar@pardus.org.tr \
    --cc=fseidel@suse.de \
    --cc=hirofumi@mail.parknet.co.jp \
    --cc=linux-kernel@vger.kernel.org \
    --cc=onur@pardus.org.tr \
    --cc=torvalds@linux-foundation.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.