All of lore.kernel.org
 help / color / mirror / Atom feed
From: Stefan Roese <sr-ynQEQJNshbs@public.gmane.org>
To: Jean Delvare <khali-PUYAD+kWke1g9hUCZPvPmw@public.gmane.org>
Cc: linuxppc-dev-mnsaURCQ41sdnm+yROfE0A@public.gmane.org,
	i2c-GZX6beZjE8VD60Wz+7aTrA@public.gmane.org
Subject: Re: [PATCH] i2c-ibm_iic: Enable driver for all PPC4xx variants in arch/powerpc
Date: Mon, 9 Jun 2008 06:48:24 +0200	[thread overview]
Message-ID: <200806090648.24339.sr@denx.de> (raw)
In-Reply-To: <20080608144843.58857324-ig7AzVSIIG7kN2dkZ6Wm7A@public.gmane.org>

Hi Jean,

On Sunday 08 June 2008, Jean Delvare wrote:
> > This patch enables the IBM I2C driver for all PPC4xx variants by adding
> > "ibm,iic" to the compatible list. This way all currently available
> > arch/powerpc 4xx ports can make use of this driver without any changes.
> > Additionally all "other" compatible entries are removed since they are
> > not needed anymore.
> >
> > Currently all 4xx PPC's have the same compatible I2C macro. If at some
> > time an incompatibility is detected we can take care of this with an
> > additional property.
> >
> > Signed-off-by: Stefan Roese <sr-ynQEQJNshbs@public.gmane.org>
> > ---
> >  drivers/i2c/busses/i2c-ibm_iic.c |    6 +-----
> >  1 files changed, 1 insertions(+), 5 deletions(-)
> >
> > diff --git a/drivers/i2c/busses/i2c-ibm_iic.c
> > b/drivers/i2c/busses/i2c-ibm_iic.c index 3a364a7..ed73801 100644
> > --- a/drivers/i2c/busses/i2c-ibm_iic.c
> > +++ b/drivers/i2c/busses/i2c-ibm_iic.c
> > @@ -807,11 +807,7 @@ static int __devexit iic_remove(struct of_device
> > *ofdev) }
> >
> >  static const struct of_device_id ibm_iic_match[] = {
> > -	{ .compatible = "ibm,iic-405ex", },
> > -	{ .compatible = "ibm,iic-405gp", },
> > -	{ .compatible = "ibm,iic-440gp", },
> > -	{ .compatible = "ibm,iic-440gpx", },
> > -	{ .compatible = "ibm,iic-440grx", },
> > +	{ .compatible = "ibm,iic", },
> >  	{}
> >  };
>
> OK, I can take this in my tree, unless it depends on arch-specific
> patches which have not hit mainline yet.

No, this doesn't depend on other pathes.

> I guess this is 2.6.27 
> material?

Yes. No real hurry here.

Thanks.

Best regards,
Stefan

_______________________________________________
i2c mailing list
i2c-GZX6beZjE8VD60Wz+7aTrA@public.gmane.org
http://lists.lm-sensors.org/mailman/listinfo/i2c

WARNING: multiple messages have this Message-ID (diff)
From: Stefan Roese <sr@denx.de>
To: Jean Delvare <khali@linux-fr.org>
Cc: linuxppc-dev@ozlabs.org, i2c@lm-sensors.org
Subject: Re: [PATCH] i2c-ibm_iic: Enable driver for all PPC4xx variants in arch/powerpc
Date: Mon, 9 Jun 2008 06:48:24 +0200	[thread overview]
Message-ID: <200806090648.24339.sr@denx.de> (raw)
In-Reply-To: <20080608144843.58857324@hyperion.delvare>

Hi Jean,

On Sunday 08 June 2008, Jean Delvare wrote:
> > This patch enables the IBM I2C driver for all PPC4xx variants by adding
> > "ibm,iic" to the compatible list. This way all currently available
> > arch/powerpc 4xx ports can make use of this driver without any changes.
> > Additionally all "other" compatible entries are removed since they are
> > not needed anymore.
> >
> > Currently all 4xx PPC's have the same compatible I2C macro. If at some
> > time an incompatibility is detected we can take care of this with an
> > additional property.
> >
> > Signed-off-by: Stefan Roese <sr@denx.de>
> > ---
> >  drivers/i2c/busses/i2c-ibm_iic.c |    6 +-----
> >  1 files changed, 1 insertions(+), 5 deletions(-)
> >
> > diff --git a/drivers/i2c/busses/i2c-ibm_iic.c
> > b/drivers/i2c/busses/i2c-ibm_iic.c index 3a364a7..ed73801 100644
> > --- a/drivers/i2c/busses/i2c-ibm_iic.c
> > +++ b/drivers/i2c/busses/i2c-ibm_iic.c
> > @@ -807,11 +807,7 @@ static int __devexit iic_remove(struct of_device
> > *ofdev) }
> >
> >  static const struct of_device_id ibm_iic_match[] = {
> > -	{ .compatible = "ibm,iic-405ex", },
> > -	{ .compatible = "ibm,iic-405gp", },
> > -	{ .compatible = "ibm,iic-440gp", },
> > -	{ .compatible = "ibm,iic-440gpx", },
> > -	{ .compatible = "ibm,iic-440grx", },
> > +	{ .compatible = "ibm,iic", },
> >  	{}
> >  };
>
> OK, I can take this in my tree, unless it depends on arch-specific
> patches which have not hit mainline yet.

No, this doesn't depend on other pathes.

> I guess this is 2.6.27 
> material?

Yes. No real hurry here.

Thanks.

Best regards,
Stefan

  parent reply	other threads:[~2008-06-09  4:48 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-06-05  8:10 [PATCH] i2c-ibm_iic: Enable driver for all PPC4xx variants in arch/powerpc Stefan Roese
2008-06-05  8:10 ` Stefan Roese
2008-06-05 11:27 ` Josh Boyer
2008-06-08 12:48 ` Jean Delvare
     [not found]   ` <20080608144843.58857324-ig7AzVSIIG7kN2dkZ6Wm7A@public.gmane.org>
2008-06-09  4:48     ` Stefan Roese [this message]
2008-06-09  4:48       ` Stefan Roese

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=200806090648.24339.sr@denx.de \
    --to=sr-ynqeqjnshbs@public.gmane.org \
    --cc=i2c-GZX6beZjE8VD60Wz+7aTrA@public.gmane.org \
    --cc=khali-PUYAD+kWke1g9hUCZPvPmw@public.gmane.org \
    --cc=linuxppc-dev-mnsaURCQ41sdnm+yROfE0A@public.gmane.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.