All of lore.kernel.org
 help / color / mirror / Atom feed
From: Vivek Goyal <vgoyal@redhat.com>
To: Bernhard Walle <bwalle@suse.de>
Cc: kexec@lists.infradead.org, linux-kernel@vger.kernel.org,
	mingo@redhat.com, anderson@redhat.com, hpa@zytor.com,
	tglx@linutronix.de
Subject: Re: [patch 0/3] [x86] Fix crashkernel reservation on NUMA machines
Date: Mon, 9 Jun 2008 09:06:46 -0400	[thread overview]
Message-ID: <20080609130646.GB3542@redhat.com> (raw)
In-Reply-To: <20080608134628.757299158@halley.suse.de>

On Sun, Jun 08, 2008 at 03:46:28PM +0200, Bernhard Walle wrote:
> This patch series fixes the crashkernel reservation on NUMA machine. The
> regression was discovered by Dave Anderson <anderson@redhat.com>.
> 
> The background is that on NUMA machines, reserve_bootmem_generic() is required
> instead of reserve_bootmem(). To achieve that, it's necessary to make a few
> API changes.
> 
> The patches are against latest linux-2.6 git. They should still go into 2.6.26
> since it's only bug fixing. For 2.6.27, we should unify crashkernel reservation
> for i386 and x86-64.
> 
> Tested on both i386 and x86-64. Compilation was tested with both kexec disabled
> and enabled. The change is x86 only, so no need to test on other architectures.
> 
> 
> Signed-off-by: Bernhard Walle <bwalle@suse.de>

Yes we should be using reserve_bootmem_generic() for reserving memory
on NUMA machines. Recently myself and Dave A. ran into crash while 
reserving memory using resreve_bootmem() on a NUMA machine. 

Reason for crash? reserve_bootmem() always assumes node id to be zero, and
that was not the case.

Acked-by: Vivek Goyal <vgoyal@redhat.com>

Thanks
Vivek

_______________________________________________
kexec mailing list
kexec@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/kexec

WARNING: multiple messages have this Message-ID (diff)
From: Vivek Goyal <vgoyal@redhat.com>
To: Bernhard Walle <bwalle@suse.de>
Cc: kexec@lists.infradead.org, linux-kernel@vger.kernel.org,
	hpa@zytor.com, mingo@redhat.com, tglx@linutronix.de,
	anderson@redhat.com
Subject: Re: [patch 0/3] [x86] Fix crashkernel reservation on NUMA machines
Date: Mon, 9 Jun 2008 09:06:46 -0400	[thread overview]
Message-ID: <20080609130646.GB3542@redhat.com> (raw)
In-Reply-To: <20080608134628.757299158@halley.suse.de>

On Sun, Jun 08, 2008 at 03:46:28PM +0200, Bernhard Walle wrote:
> This patch series fixes the crashkernel reservation on NUMA machine. The
> regression was discovered by Dave Anderson <anderson@redhat.com>.
> 
> The background is that on NUMA machines, reserve_bootmem_generic() is required
> instead of reserve_bootmem(). To achieve that, it's necessary to make a few
> API changes.
> 
> The patches are against latest linux-2.6 git. They should still go into 2.6.26
> since it's only bug fixing. For 2.6.27, we should unify crashkernel reservation
> for i386 and x86-64.
> 
> Tested on both i386 and x86-64. Compilation was tested with both kexec disabled
> and enabled. The change is x86 only, so no need to test on other architectures.
> 
> 
> Signed-off-by: Bernhard Walle <bwalle@suse.de>

Yes we should be using reserve_bootmem_generic() for reserving memory
on NUMA machines. Recently myself and Dave A. ran into crash while 
reserving memory using resreve_bootmem() on a NUMA machine. 

Reason for crash? reserve_bootmem() always assumes node id to be zero, and
that was not the case.

Acked-by: Vivek Goyal <vgoyal@redhat.com>

Thanks
Vivek

  parent reply	other threads:[~2008-06-09 13:06 UTC|newest]

Thread overview: 46+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-06-08 13:46 [patch 0/3] [x86] Fix crashkernel reservation on NUMA machines Bernhard Walle
2008-06-08 13:46 ` Bernhard Walle
2008-06-08 13:46 ` [patch 1/3] Add return value to reserve_bootmem_node() Bernhard Walle
2008-06-08 13:46   ` Bernhard Walle
2008-06-08 13:46 ` [patch 2/3] Add flags parameter to reserve_bootmem_generic() Bernhard Walle
2008-06-08 13:46   ` Bernhard Walle
2008-06-08 14:26   ` WANG Cong
2008-06-08 14:26     ` WANG Cong
2008-06-08 17:12     ` Bernhard Walle
2008-06-08 17:12       ` Bernhard Walle
2008-06-08 22:01   ` Johannes Weiner
2008-06-08 22:01     ` Johannes Weiner
2008-06-09 13:22     ` Vivek Goyal
2008-06-09 13:22       ` Vivek Goyal
2008-06-09 16:23       ` Bernhard Walle
2008-06-09 16:23         ` Bernhard Walle
2008-06-09 16:39         ` Andi Kleen
2008-06-09 16:39           ` Andi Kleen
2008-06-09 19:50           ` Amul Shah
2008-06-09 19:50             ` Amul Shah
2008-06-09 20:17             ` Bernhard Walle
2008-06-09 20:17               ` Bernhard Walle
2008-06-09 20:29               ` Vivek Goyal
2008-06-09 20:29                 ` Vivek Goyal
2008-06-09 20:42                 ` Bernhard Walle
2008-06-09 20:42                   ` Bernhard Walle
2008-06-09 20:54                   ` Vivek Goyal
2008-06-09 20:54                     ` Vivek Goyal
2008-06-09 20:57                     ` Bernhard Walle
2008-06-09 20:57                       ` Bernhard Walle
2008-06-09 21:00                       ` Vivek Goyal
2008-06-09 21:00                         ` Vivek Goyal
2008-06-09 21:04                         ` Bernhard Walle
2008-06-09 21:04                           ` Bernhard Walle
2008-06-09 16:25     ` Bernhard Walle
2008-06-09 16:25       ` Bernhard Walle
2008-06-08 22:06   ` Johannes Weiner
2008-06-08 22:06     ` Johannes Weiner
2008-06-09 16:37     ` Bernhard Walle
2008-06-09 16:37       ` Bernhard Walle
2008-06-08 13:46 ` [patch 3/3] Use reserve_bootmem_generic() to reserve crashkernel memory on x86_64 Bernhard Walle
2008-06-08 13:46   ` Bernhard Walle
2008-06-09 13:06 ` Vivek Goyal [this message]
2008-06-09 13:06   ` [patch 0/3] [x86] Fix crashkernel reservation on NUMA machines Vivek Goyal
2008-06-10 12:44 ` Ingo Molnar
2008-06-10 12:44   ` Ingo Molnar

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20080609130646.GB3542@redhat.com \
    --to=vgoyal@redhat.com \
    --cc=anderson@redhat.com \
    --cc=bwalle@suse.de \
    --cc=hpa@zytor.com \
    --cc=kexec@lists.infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mingo@redhat.com \
    --cc=tglx@linutronix.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.