All of lore.kernel.org
 help / color / mirror / Atom feed
From: Robert Millan <rmh@aybabtu.com>
To: The development of GRUB 2 <grub-devel@gnu.org>
Subject: Re: Some concern about the journal support
Date: Sat, 14 Jun 2008 20:06:30 +0200	[thread overview]
Message-ID: <20080614180630.GD5636@thorin> (raw)
In-Reply-To: <ca0f59980806141032y354f48d2o4aab4655285b2157@mail.gmail.com>

On Sun, Jun 15, 2008 at 01:32:23AM +0800, Bean wrote:
> -/* Read LEN bytes from the block BLOCK on disk DISK into the buffer BUF,
> -   beginning with the block POS.  Apply mappings from LOG.  The blocks
> -   have a size of LOG2BLOCKSIZE (in log2).  */
> -grub_err_t grub_fshelp_read (grub_disk_t disk, grub_fshelp_journal_t log,
> -			     grub_disk_addr_t block, grub_off_t pos,
> -			     grub_size_t len, char *buf, int log2blocksize)
> -{
> [...]
> -
> -grub_disk_addr_t
> -grub_fshelp_map_block (grub_fshelp_journal_t log, grub_disk_addr_t block)
> -{

Why are these functions removed?  I suppose they were only useful for journal
handling?  But they predate journal support, which is a bit confusing..

-- 
Robert Millan

<GPLv2> I know my rights; I want my phone call!
<DRM> What good is a phone call… if you are unable to speak?
(as seen on /.)



  reply	other threads:[~2008-06-14 18:07 UTC|newest]

Thread overview: 21+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-06-13  9:05 Some concern about the journal support Bean
2008-06-13 10:01 ` Bean
2008-06-13 12:14   ` Bean
2008-06-13 15:55 ` Pavel Roskin
2008-06-13 17:05   ` Bean
2008-06-13 19:45     ` Isaac Dupree
2008-06-13 20:40       ` Pavel Roskin
2008-06-13 21:49         ` Isaac Dupree
2008-06-13 22:06           ` Pavel Roskin
2008-06-14  3:32         ` Bean
2008-06-14  4:11           ` Bean
2008-06-13 20:14     ` Pavel Roskin
2008-06-14 11:43       ` Robert Millan
2008-06-14 16:17         ` Bean
2008-06-14 17:32           ` Bean
2008-06-14 18:06             ` Robert Millan [this message]
2008-06-14 18:29               ` Bean
2008-06-14 18:48                 ` Robert Millan
2008-06-14 18:14             ` Javier Martín
2008-06-16  1:27             ` Pavel Roskin
2008-06-16 19:02               ` Bean

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20080614180630.GD5636@thorin \
    --to=rmh@aybabtu.com \
    --cc=grub-devel@gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.